Skip to content

Commit 4eea241

Browse files
committed
gs recovery debugged
1 parent a54ce8f commit 4eea241

6 files changed

Lines changed: 26 additions & 18 deletions

File tree

scripts/run_all.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ run_grn_inference=false
88
run_grn_evaluation=true
99
run_download=false
1010

11+
num_workers=20
12+
1113

1214
for dataset in "${datasets[@]}"; do
1315
trace_file="resources/results/$dataset/trace.txt"
@@ -56,7 +58,7 @@ for dataset in "${datasets[@]}"; do
5658
# fi
5759

5860
echo "Running GRN evaluation for dataset: $dataset"
59-
bash scripts/run_grn_evaluation.sh --dataset=$dataset --run_local=$run_local --build_images=false
61+
bash scripts/run_grn_evaluation.sh --dataset=$dataset --run_local=$run_local --build_images=false --num_workers=$num_workers
6062
fi
6163

6264
if [ "$run_download" = true ]; then

scripts/run_grn_evaluation.sh

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ RUN_LOCAL="true"
88
RUN_TEST=false
99
PREDICTION="none"
1010
SAVE_DIR="none"
11-
BUILD_IMAGES=false
11+
BUILD_IMAGES=true
1212
reg_type="ridge"
13+
num_workers=4
1314

1415

1516
# Parse arguments
@@ -43,6 +44,10 @@ for arg in "$@"; do
4344
reg_type="${arg#*=}"
4445
shift
4546
;;
47+
--num_workers=*)
48+
num_workers="${arg#*=}"
49+
shift
50+
;;
4651
*)
4752
echo "Unknown argument: $arg"
4853
exit 1
@@ -63,8 +68,6 @@ if [ -z "${DATASET:-}" ]; then
6368
exit 1
6469
fi
6570

66-
67-
num_workers=10
6871
RUN_ID="${DATASET}_evaluation"
6972
models_folder="${DATASET}/"
7073
apply_tf=true
@@ -132,13 +135,15 @@ append_entry() {
132135
else
133136
layer_=$layer
134137
fi
138+
135139
cat >> "$param_local" << HERE
136140
- id: ${grn_name}_${dataset}
137141
metric_ids: ${metric_ids}
138142
evaluation_data: ${resources_dir}/grn_benchmark/evaluation_data/${dataset}_bulk.h5ad
139143
tf_all: ${resources_dir}/grn_benchmark/prior/tf_all.csv
140144
regulators_consensus: ${resources_dir}/grn_benchmark/prior/regulators_consensus_${dataset}.json
141145
prediction: ${prediction}
146+
num_workers: ${num_workers}
142147
apply_tf: ${apply_tf}
143148
reg_type: ${reg_type}
144149
layer: $layer_
@@ -229,7 +234,7 @@ HERE
229234
-profile docker \
230235
-with-trace \
231236
-params-file ${param_local} \
232-
# -c common/nextflow_helpers/labels_ci.config
237+
-c common/nextflow_helpers/labels_ci.config
233238
else
234239
cat >> "$param_file" << HERE
235240
output_state: "state.yaml"

scripts/sync_resources.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ set -e
1717
# aws s3 sync s3://openproblems-data/resources/grn/results/op resources/results/op --no-sign-request
1818

1919
# aws s3 sync s3://openproblems-data/resources/grn/grn_models resources/grn_models --delete
20-
# aws s3 sync resources_test/ s3://openproblems-data/resources_test/grn/ --delete
2120

2221

2322

2423
# aws s3 sync s3://openproblems-data/resources/grn/grn_benchmark resources/grn_benchmark/ --no-sign-request
2524
# aws s3 sync resources/grn_benchmark/prior s3://openproblems-data/resources/grn/grn_benchmark/prior --delete
2625
# aws s3 sync resources/extended_data/ s3://openproblems-data/resources/grn/extended_data --delete
2726
# aws s3 sync resources/results/experiment s3://openproblems-data/resources/grn/results/experiment --delete
28-
aws s3 sync resources_test s3://openproblems-data/resources_test/grn/ --delete
27+
# aws s3 sync resources_test s3://openproblems-data/resources_test/grn/ --delete
28+
aws s3 sync s3://openproblems-data/resources_test/grn/ resources_test --delete
2929
# aws s3 sync resources/grn_benchmark/ground_truth s3://openproblems-data/resources/grn/grn_benchmark/ground_truth
3030
# aws s3 sync resources/grn_benchmark/ s3://openproblems-data/resources/grn/grn_benchmark/ --delete
3131

src/metrics/gs_recovery/script.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,20 @@
1515
'num_workers': 20,
1616
'tf_all': 'resources/grn_benchmark/prior/tf_all.csv',
1717
'score': 'output/score.h5ad',
18-
'pathway_file': '/vol/projects/jnourisa/prior/h.all.v2024.1.Hs.symbols.gmt',
1918
'fdr_threshold': 0.05,
2019
'min_pathway_size': 5,
2120
'max_pathway_size': 500,
2221
'min_targets': 10,
2322
'max_targets': 100, # Top K edges by absolute weight
24-
'ulm_baseline_method': 'zero_centered',
25-
'output_detailed_metrics': True
23+
'ulm_baseline_method': 'zero_centered'
2624
}
2725
## VIASH END
2826

27+
run_local=False
2928
try:
3029
sys.path.append(meta["resources_dir"])
3130
except:
31+
run_local=True
3232
meta = {
3333
"resources_dir":'src/metrics/experimental/annotation/',
3434
"util_dir": 'src/utils',
@@ -38,10 +38,11 @@
3838
from helper import main as main_helper
3939
from util import format_save_score, parse_args
4040

41-
par = parse_args(par)
41+
if run_local:
42+
par = parse_args(par)
4243

4344
if __name__ == "__main__":
44-
45+
print(par)
4546
output = main_helper(par)
4647
print(output)
4748

src/utils/dataset_config.env

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ METRICS_replogle="regression,ws_distance,tf_recovery,tf_binding,sem,gs_recovery"
1919
METRICS_adamson="regression,tf_binding,sem,gs_recovery"
2020
METRICS_norman="regression,ws_distance,tf_binding,sem,gs_recovery"
2121
METRICS_nakatake="regression,sem,gs_recovery"
22-
METRICS_op="regression,vc,rc_tf_act,tf_binding,sem,rc,anchor_regression,gs_recovery"
23-
METRICS_300BCG="regression,vc,rc_tf_act,tf_binding,sem,rc,anchor_regression,gs_recovery"
24-
METRICS_ibd_uc="regression,vc,tf_binding,sem,anchor_regression,gs_recovery"
25-
METRICS_ibd_cd="regression,vc,tf_binding,sem,anchor_regression,gs_recovery"
26-
METRICS_parsebioscience="regression,vc,rc_tf_act,tf_binding,sem,rc,anchor_regression,gs_recovery"
22+
METRICS_op="gs_recovery"
23+
METRICS_300BCG="regression,vc,rc_tf_act,tf_binding,sem,gs_recovery"
24+
METRICS_ibd_uc="regression,vc,tf_binding,sem,gs_recovery"
25+
METRICS_ibd_cd="regression,vc,tf_binding,sem,gs_recovery"
26+
METRICS_parsebioscience="regression,vc,rc_tf_act,tf_binding,sem,gs_recovery"
2727
METRICS_xaira_HEK293T="regression,ws_distance,tf_recovery,tf_binding,sem,gs_recovery"
2828
METRICS_xaira_HCT116="regression,ws_distance,tf_recovery,tf_binding,sem,gs_recovery"

0 commit comments

Comments
 (0)