Skip to content

Commit f1240b7

Browse files
committed
change default params
1 parent 625a51e commit f1240b7

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/methods_cell_type_annotation/moscot/config.vsh.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ references:
1111
doi: "10.1038/s41586-024-08453-2"
1212

1313
arguments:
14-
# TODO: alpha check range [0.9, 0.8, 0.7]
15-
# TODO: tau_a=tau_b check range [0.1,0.2,0.3]
16-
# TODO: rank depends on data set size, rank=5000 for 300k cells and down to rank=500 minimal
14+
# TODO: alpha check range [0.7, 0.8, 0.9]
15+
# TODO: tau_a=tau_b check range [0.1, 0.2, 0.3] (seems only to work with tau=1 on our data)
16+
# TODO: rank depends on data set size, rank=5000 for 300k cells and down to rank=500 minimum (seems only to work with rank=-1 on our data)
1717
- name: --alpha
1818
required: false
1919
direction: input
2020
type: double
21-
default: 0.5
21+
default: 0.8
2222
- name: --tau
2323
required: false
2424
direction: input

src/methods_cell_type_annotation/moscot/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
'output': 'spatial_with_celltypes.h5ad',
1515
'celltype_key': 'cell_type',
1616
'alpha': 0.8,
17-
'tau': 0.2,
18-
'rank': 5000,
17+
'tau': 1.0,
18+
'rank': -1,
1919
'mapping_mode': 'max',
2020
}
2121
meta = {

0 commit comments

Comments
 (0)