OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

src/main/java/org/openrewrite/java/testing/cleanup/KotlinTestMethodsShouldReturnUnit.java

@@ -16,6 +16,7 @@
 package org.openrewrite.java.testing.cleanup;
 
 import lombok.Getter;
+import org.jspecify.annotations.Nullable;
 import org.openrewrite.*;
 import org.openrewrite.java.AnnotationMatcher;
 import org.openrewrite.java.search.UsesType;
@@ -105,7 +106,7 @@ public J.NewClass visitNewClass(J.NewClass newClass, ExecutionContext ctx) {
         }
 
         @Override
-        public J visitReturn(K.Return return_, ExecutionContext ctx) {
+        public @Nullable J visitReturn(K.Return return_, ExecutionContext ctx) {
             Expression returnExpr = return_.getExpression().getExpression();
             //noinspection DataFlowIssue
             return returnExpr instanceof Statement ?

src/main/java/org/openrewrite/java/testing/testcontainers/ReplaceContainerImageName.java

@@ -50,16 +50,10 @@ public class ReplaceContainerImageName extends Recipe {
             example = "apache/kafka-native:4.0.2")
     String newImage;
 
-    @Override
-    public String getDisplayName() {
-        return "Replace container image name";
-    }
+    String displayName = "Replace container image name";
 
-    @Override
-    public String getDescription() {
-        return "Replace a Docker image name in `DockerImageName.parse(image)` or " +
-               "`new DockerImageName(image)` constructor arguments for a specific container class.";
-    }
+    String description = "Replace a Docker image name in `DockerImageName.parse(image)` or " +
+            "`new DockerImageName(image)` constructor arguments for a specific container class.";
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/resources/META-INF/rewrite/examples.yml

@@ -5248,6 +5248,27 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.testing.testcontainers.MigrateToKafkaNative
+examples:
+- description: '`MigrateToKafkaNativeTest#migrateToKafkaNative`'
+  sources:
+  - before: |
+      import org.testcontainers.containers.KafkaContainer;
+      import org.testcontainers.utility.DockerImageName;
+
+      class A {
+          KafkaContainer kafka = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:7.5.3"));
+      }
+    after: |
+      import org.testcontainers.kafka.KafkaContainer;
+      import org.testcontainers.utility.DockerImageName;
+
+      class A {
+          KafkaContainer kafka = new KafkaContainer(DockerImageName.parse("apache/kafka-native:4.0.2"));
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.testing.testcontainers.MigrateToOracleFree
 examples:
 - description: '`MigrateToOracleFreeTest#changeTypeAndImport`'
@@ -5267,6 +5288,31 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.testing.testcontainers.ReplaceContainerImageName
+examples:
+- description: '`ReplaceContainerImageNameTest#replaceConfluentWithKafkaNative`'
+  parameters:
+  - org.testcontainers.containers.KafkaContainer
+  - confluentinc/cp-kafka
+  - apache/kafka-native:4.0.2
+  sources:
+  - before: |
+      import org.testcontainers.containers.KafkaContainer;
+      import org.testcontainers.utility.DockerImageName;
+
+      class A {
+          KafkaContainer kafka = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:7.5.3"));
+      }
+    after: |
+      import org.testcontainers.containers.KafkaContainer;
+      import org.testcontainers.utility.DockerImageName;
+
+      class A {
+          KafkaContainer kafka = new KafkaContainer(DockerImageName.parse("apache/kafka-native:4.0.2"));
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.testing.testcontainers.TestContainersBestPractices
 examples:
 - description: '`TestcontainersBestPracticesTest#getHost`'

src/test/java/org/openrewrite/java/testing/mockito/RemoveTimesZeroAndOneTest.java

@@ -17,8 +17,8 @@
 
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
-import org.openrewrite.Issue;
 import org.openrewrite.InMemoryExecutionContext;
+import org.openrewrite.Issue;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
@@ -96,8 +96,8 @@ void test(Object myObject) {
         );
     }
 
-    @Test
     @Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/968")
+    @Test
     void retainVerificationModeIdentifier() {
         rewriteRun(
           //language=Java