Skip to content

Commit 17ef798

Browse files
Replace getEstimatedEffortPerOccurrence() method with field
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.recipes.UseEstimatedEffortPerOccurrenceField?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl Co-authored-by: Moderne <team@moderne.io>
1 parent 49b6e85 commit 17ef798

7 files changed

Lines changed: 13 additions & 28 deletions

File tree

src/main/java/org/openrewrite/java/testing/cleanup/RemoveEmptyTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,8 @@ public class RemoveEmptyTests extends Recipe {
3939
@Getter
4040
final String description = "Removes empty methods with a `@Test` annotation if the body does not have comments.";
4141

42-
@Override
43-
public Duration getEstimatedEffortPerOccurrence() {
44-
return Duration.ofMinutes(2);
45-
}
42+
@Getter
43+
final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(2);
4644

4745
@Getter
4846
final Set<String> tags = singleton("RSPEC-S1186");

src/main/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefix.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,8 @@ public class RemoveTestPrefix extends Recipe {
5555
@Getter
5656
final String description = "Remove `test` from methods with `@Test`, `@ParameterizedTest`, `@RepeatedTest` or `@TestFactory`. They no longer have to prefix test to be usable by JUnit 5.";
5757

58-
@Override
59-
public Duration getEstimatedEffortPerOccurrence() {
60-
return Duration.ofMinutes(1);
61-
}
58+
@Getter
59+
final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
6260

6361
@Override
6462
public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/java/testing/cleanup/SimplifyTestThrows.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,8 @@ public class SimplifyTestThrows extends Recipe {
4040
@Getter
4141
final String description = "Replace all thrown exception classes of test method signatures by `Exception`.";
4242

43-
@Override
44-
public Duration getEstimatedEffortPerOccurrence() {
45-
return Duration.ofMinutes(1);
46-
}
43+
@Getter
44+
final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
4745

4846
@Override
4947
public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/java/testing/junit5/AddMissingNested.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ public class AddMissingNested extends Recipe {
5757

5858
String description = "Adds `@Nested` to inner classes that contain JUnit 5 tests.";
5959

60-
@Override
61-
public Duration getEstimatedEffortPerOccurrence() {
62-
return Duration.ofMinutes(1);
63-
}
60+
Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
6461

6562
Set<String> tags = singleton("RSPEC-S5790");
6663

src/main/java/org/openrewrite/java/testing/junit5/LifecycleNonPrivate.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ public J.MethodDeclaration visitMethodDeclaration(MethodDeclaration method, Exec
7777
}
7878
}
7979

80-
@Override
81-
public Duration getEstimatedEffortPerOccurrence() {
82-
return Duration.ofMinutes(1);
83-
}
80+
@Getter
81+
final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
8482

8583
}

src/main/java/org/openrewrite/java/testing/junit5/TempDirNonFinal.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ private static boolean isField(Cursor cursor) {
7272
return true;
7373
}
7474

75-
@Override
76-
public Duration getEstimatedEffortPerOccurrence() {
77-
return Duration.ofMinutes(1);
78-
}
75+
@Getter
76+
final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
7977
}

src/main/java/org/openrewrite/java/testing/mockito/AnyStringToNullable.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,8 @@ public class AnyStringToNullable extends Recipe {
4141
@Getter
4242
final String description = "Since Mockito 2.10 `anyString()` no longer matches null values. Use `nullable(Class)` instead.";
4343

44-
@Override
45-
public Duration getEstimatedEffortPerOccurrence() {
46-
return Duration.ofMinutes(1);
47-
}
44+
@Getter
45+
final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
4846

4947
@Override
5048
public TreeVisitor<?, ExecutionContext> getVisitor() {

0 commit comments

Comments
 (0)