Pass error raising test

Author: znicholls

src/example_fgen_basic/get_square_root.py

@@ -47,15 +47,23 @@ def get_square_root(inv: float) -> float:
         TODO: use a more specific error
     """
     result_instance_index: int = m_get_square_root_w.get_square_root(inv)
-
     result = ResultDP.from_instance_index(result_instance_index)
 
     if result.has_error:
         # TODO: be more specific
         raise FortranError(result.error_v.message)
+        # raise LessThanZeroError(result.error_v.message)
 
     res = result.data_v
 
+    # TODO: think
+    # I like the clarity of finalising result_instance_index here
+    # by having an explicit call
+    # (so you can see creation and finalisation in same place).
+    # (Probably the above is my preferred right now, but we should think about it.)
+    # I like the safety of finalising in `from_instance_index`.
+    # if not finalised(result_instance_index):
+    #     finalise(result_instance_index)
     m_result_dp_w.finalise_instance(result_instance_index)
 
     return res

src/example_fgen_basic/get_square_root_wrapper.f90

@@ -42,11 +42,6 @@ function get_square_root(inv) result(res_instance_index)
         ! ready for its attributes to be retrieved from Python.
         call result_dp_manager_set_instance_index_to(res_instance_index, res)
 
-        print *, "res_instance_index"
-        print *, res_instance_index
-        print *, "res % data_v"
-        print *, res % data_v
-
     end function get_square_root
 
 end module m_get_square_root_w

src/example_fgen_basic/result/result_dp_wrapper.f90

@@ -7,6 +7,7 @@ module m_result_dp_w
     ! The manager module, which makes this all work
     use m_error_v_manager, only: &
         error_v_manager_get_instance => get_instance, &
+        error_v_manager_ensure_instance_array_size_is_at_least => ensure_instance_array_size_is_at_least, &
         error_v_manager_get_available_instance_index => get_available_instance_index, &
         error_v_manager_set_instance_index_to => set_instance_index_to
 
@@ -137,13 +138,9 @@ subroutine get_data_v( &
 
         type(ResultDP)  :: instance
 
-        print *, "instance_index"
-        print *, instance_index
         instance = result_dp_manager_get_instance(instance_index)
 
         data_v = instance % data_v
-        print *, "instance % data_v"
-        print *, instance % data_v
 
     end subroutine get_data_v
 
@@ -181,6 +178,8 @@ subroutine get_error_v( &
         instance = result_dp_manager_get_instance(instance_index)
 
         error_v = instance % error_v
+
+        call error_v_manager_ensure_instance_array_size_is_at_least(1)
         call error_v_manager_get_available_instance_index(error_v_instance_index)
         call error_v_manager_set_instance_index_to(error_v_instance_index, error_v)
 

tests/unit/test_get_square_root.py

@@ -12,7 +12,7 @@
     "inv, exp, exp_error",
     (
         (4.0, 2.0, None),
-        (-4.0, None, pytest.raises(FortranError, match="inv is negative")),
+        (-4.0, None, pytest.raises(FortranError, match="Input value was negative")),
     ),
 )
 def test_basic(inv, exp, exp_error):