Correction for mypy

Author: mzecc

src/example_fgen_basic/get_square_root.py

@@ -70,7 +70,16 @@ def get_square_root(inv: float) -> float:
 
     if state != 0:
         error = ResultGen.from_instance_index(state)
-        message = error.error_v.message.decode("utf-8")
+
+        if error.error_v is None:
+            msg = (
+                f"Finalisation of index {result_instance_index} failed with "
+                f"state {state} but returned no error details."
+            )
+            raise AssertionError(msg)
+
+        message = error.error_v.message
+
         raise FortranError(error.error_v.code, message)
 
     return res

src/example_fgen_basic/result/result_gen.py

@@ -70,7 +70,8 @@ def from_instance_index(cls, instance_index: int) -> ResultGen:
             code, message = m_result_w.get_error(instance_index)
             # if code is None or message is None:
             # raise ValueError("Fortran returned incomplete error information")
-            error_v = ErrorV(code=code, message=message)
+            clean_msg = message.decode("utf-8").strip()
+            error_v = ErrorV(code=code, message=clean_msg)
 
             res = cls(data_v=data_v_err, error_v=error_v)
         else:

src/example_fgen_basic/result/result_manager.f90

@@ -96,6 +96,7 @@ function finalise_instance(instance_index) result(state_index)
                               )
 
           return
+
       end if
 
       state_index = 0

tests/unit/test_result_gen.py

@@ -37,7 +37,7 @@ def test_create_error_result():
 
     result_instance_index = result_in.build_fortran_instance()
     result_out = ResultGen.from_instance_index(result_instance_index)
-    result_out.error_v.message = result_out.error_v.message.decode("utf-8")
+    result_out.error_v.message = result_out.error_v.message
 
     assert result_in.data_v == result_out.data_v
     assert result_in.error_v == result_out.error_v
@@ -57,7 +57,7 @@ def test_create_mix_results():
         result_out = ResultGen.from_instance_index(result_instance_index)
 
         if result_out.error_v:
-            result_out.error_v.message = result_out.error_v.message.decode("utf-8")
+            result_out.error_v.message = result_out.error_v.message
 
         assert res.data_v == result_out.data_v
         assert res.error_v == result_out.error_v
@@ -71,7 +71,7 @@ def test_out_of_alloc_and_bound_error():
     result_out = ResultGen.from_instance_index(1)
 
     if result_out.error_v:
-        result_out.error_v.message = result_out.error_v.message.decode("utf-8")
+        result_out.error_v.message = result_out.error_v.message
 
     assert (
         result_out.error_v.message
@@ -82,7 +82,7 @@ def test_out_of_alloc_and_bound_error():
     result_out = ResultGen.from_instance_index(result_instance_index + 10)
 
     if result_out.error_v:
-        result_out.error_v.message = result_out.error_v.message.decode("utf-8")
+        result_out.error_v.message = result_out.error_v.message
 
     assert (
         result_out.error_v.message