Skip to content

Commit f60b408

Browse files
committed
Corrected create_errors small mistake
1 parent 0174330 commit f60b408

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

src/example_fgen_basic/error_v/creation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def create_error(inv: int) -> ErrorV:
5757
return res
5858

5959

60-
def create_errors(invs: NP_ARRAY_OF_INT) -> tuple[ErrorV, ...]:
60+
def create_errors(invs: NP_ARRAY_OF_INT, n: int) -> tuple[ErrorV, ...]:
6161
"""
6262
Create a number of errors
6363

src/example_fgen_basic/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
srcs += files(
22
'error_v/creation.f90',
33
'error_v/error_v.f90',
4+
'error_v/passing.f90',
45
'fpyfgen/base_finalisable.f90',
56
'get_wavelength.f90',
67
'kind_parameters.f90',

tests/unit/test_error_v_creation.f90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ end subroutine collect_error_v_creation_tests
2727

2828
subroutine test_error_v_creation_basic(error)
2929
use m_error_v, only: ErrorV
30-
use m_error_v_passing, only: create_error
30+
use m_error_v_creation, only: create_error
3131

3232
type(error_type), allocatable, intent(out) :: error
3333

@@ -46,7 +46,7 @@ end subroutine test_error_v_creation_basic
4646

4747
subroutine test_error_v_creation_edge(error)
4848
use m_error_v, only: ErrorV
49-
use m_error_v_passing, only: create_error
49+
use m_error_v_creation, only: create_error
5050

5151
type(error_type), allocatable, intent(out) :: error
5252

tests/unit/test_error_v_creation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_create_error_even():
2929
assert res.message == "Even number supplied"
3030

3131

32-
@pytest.mark.skip(reason="Not implemented")
32+
@pytest.mark.xfail(reason="Not implemented")
3333
def test_create_error_negative_raises():
3434
# TODO: switch to more precise error type
3535
with pytest.raises(FortranError):
@@ -48,7 +48,7 @@ def test_create_error_lots_of_repeated_calls():
4848

4949

5050
def test_create_multiple_errors():
51-
res = create_errors(np.arange(6))
51+
res = create_errors(np.arange(6), 6)
5252

5353
for i, v in enumerate(res):
5454
if i % 2 == 0:

0 commit comments

Comments
 (0)