config/v1: add installNetworkObservability field for day-0 installation

Add installNetworkObservability field to enable network observability
installation during cluster deployment (day-0).

- Add InstallNetworkObservability field to NetworkSpec
- Add NetworkObservabilityInstall feature gate enabled in DevPreview and TechPreview
- Add integration test suite for the new field

Related: openshift/enhancements#1908

Author: OlivierCazade

config/v1/tests/networks.config.openshift.io/NetworkObservabilityInstall.yaml

@@ -0,0 +1,18 @@
+apiVersion: apiextensions.k8s.io/v1 # Hack because controller-gen complains if we don't have this
+name: "Network"
+crdName: networks.config.openshift.io
+featureGates:
+  - NetworkObservabilityInstall
+tests:
+  onCreate:
+    - name: Should be able to set InstallNetworkObservability
+      initial: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          installNetworkObservability: "Enable"
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          installNetworkObservability: "Enable"

config/v1/types_network.go

@@ -86,6 +86,14 @@ type NetworkSpec struct {
 	//
 	// +optional
 	NetworkDiagnostics NetworkDiagnostics `json:"networkDiagnostics"`
+
+	// installNetworkObservability is an optional field that enables network observability
+	// when omitted or set to enable.  If the field is set to disable, it does nothing.
+	// Valid values are "", "Enable", "Disable".
+	// +openshift:enable:FeatureGate=NetworkObservabilityInstall
+	// +kubebuilder:validation:Enum:="";Enable;Disable
+	// +optional
+	InstallNetworkObservability *string `json:"installNetworkObservability,omitempty"`
 }
 
 // NetworkStatus is the current network configuration.

features/features.go

@@ -1004,4 +1004,12 @@ var (
 					enhancementPR("https://github.com/openshift/enhancements/pull/1933").
 					enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
 					mustRegister()
+
+	FeatureGateNetworkObservabilityInstall = newFeatureGate("NetworkObservabilityInstall").
+						reportProblemsToJiraComponent("netobserv").
+						contactPerson("jtakvori").
+						productScope(ocpSpecific).
+						enhancementPR("https://github.com/openshift/enhancements/pull/1908").
+						enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
+						mustRegister()
 )