config/v1: add networkObservability field for day-0 installation

Add networkObservability nested structure to configure network observability
installation during cluster deployment (day-0).

- Add NetworkObservability field to NetworkSpec with NetworkObservabilitySpec type
- Add NetworkObservabilityInstallationPolicy enum ("", "InstallAndEnable", "DoNotInstall")
- Add NetworkObservabilityInstall feature gate enabled in DevPreview and TechPreview
- Add integration test suite for the new field

When installationPolicy is set to "" (empty string) or "InstallAndEnable",
network observability will be installed and enabled. When set to "DoNotInstall",
it will not be installed.

Related: openshift/enhancements#1908

Author: OlivierCazade

config/v1/tests/networks.config.openshift.io/NetworkObservabilityInstall.yaml

@@ -0,0 +1,46 @@
+apiVersion: apiextensions.k8s.io/v1 # Hack because controller-gen complains if we don't have this
+name: "Network"
+crdName: networks.config.openshift.io
+featureGates:
+  - NetworkObservabilityInstall
+tests:
+  onCreate:
+    - name: Should be able to set NetworkObservability with empty string (default)
+      initial: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          networkObservability:
+            installationPolicy: ""
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          networkObservability:
+            installationPolicy: ""
+    - name: Should be able to set NetworkObservability InstallAndEnable
+      initial: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          networkObservability:
+            installationPolicy: InstallAndEnable
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          networkObservability:
+            installationPolicy: InstallAndEnable
+    - name: Should be able to set NetworkObservability DoNotInstall
+      initial: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          networkObservability:
+            installationPolicy: DoNotInstall
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: Network
+        spec:
+          networkObservability:
+            installationPolicy: DoNotInstall

config/v1/types_network.go

@@ -86,6 +86,13 @@ type NetworkSpec struct {
 	//
 	// +optional
 	NetworkDiagnostics NetworkDiagnostics `json:"networkDiagnostics"`
+
+	// networkObservability is an optional field that configures network observability installation
+	// during cluster deployment (day-0).
+	// When omitted, network observability will be installed unless this is a SNO cluster.
+	// +openshift:enable:FeatureGate=NetworkObservabilityInstall
+	// +optional
+	NetworkObservability NetworkObservabilitySpec `json:"networkObservability,omitempty,omitzero"`
 }
 
 // NetworkStatus is the current network configuration.
@@ -304,3 +311,31 @@ type NetworkDiagnosticsTargetPlacement struct {
 	// +listType=atomic
 	Tolerations []corev1.Toleration `json:"tolerations"`
 }
+
+// NetworkObservabilityInstallationPolicy is an enumeration of the available network observability installation policies
+// Valid values are "", "InstallAndEnable", "DoNotInstall".
+// +kubebuilder:validation:Enum="";InstallAndEnable;DoNotInstall
+type NetworkObservabilityInstallationPolicy string
+
+const (
+	// NetworkObservabilityNoOpinion means that the user has no opinion and the platform is left
+	// to choose reasonable defaults. The current default is to install and enable network observability.
+	// This is subject to change over time.
+	NetworkObservabilityNoOpinion NetworkObservabilityInstallationPolicy = ""
+	// NetworkObservabilityInstallAndEnable means that network observability should be installed and enabled during cluster deployment
+	NetworkObservabilityInstallAndEnable NetworkObservabilityInstallationPolicy = "InstallAndEnable"
+	// NetworkObservabilityDoNotInstall means that network observability should not be installed
+	NetworkObservabilityDoNotInstall NetworkObservabilityInstallationPolicy = "DoNotInstall"
+)
+
+// NetworkObservabilitySpec defines the configuration for network observability installation
+// +kubebuilder:validation:MinProperties=1
+type NetworkObservabilitySpec struct {
+	// installationPolicy controls whether network observability is installed during cluster deployment.
+	// Valid values are "", "InstallAndEnable" and "DoNotInstall".
+	// When set to "", network observability will be installed unless this is a SNO cluster.
+	// When set to "InstallAndEnable", network observability will be installed and enabled.
+	// When set to "DoNotInstall", network observability will not be installed.
+	// +optional
+	InstallationPolicy *NetworkObservabilityInstallationPolicy `json:"installationPolicy,omitempty"`
+}

features/features.go

@@ -1004,4 +1004,12 @@ var (
 					enhancementPR("https://github.com/openshift/enhancements/pull/1933").
 					enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
 					mustRegister()
+
+	FeatureGateNetworkObservabilityInstall = newFeatureGate("NetworkObservabilityInstall").
+						reportProblemsToJiraComponent("netobserv").
+						contactPerson("jtakvori").
+						productScope(ocpSpecific).
+						enhancementPR("https://github.com/openshift/enhancements/pull/1908").
+						enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
+						mustRegister()
 )