Fix remaining unused test parameters

- Rename unused 'ns', 'r', and 'ctx' parameters to underscore in test files
- Add nolint directives for additional package naming issues in constants.go and apidiscovery_test.go

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: Anand Kumar

pkg/controller/common/constants.go

@@ -1,3 +1,4 @@
+//nolint:revive // common is an established package name in this codebase
 package common
 
 const (

pkg/controller/istiocsr/certificates_test.go

@@ -23,15 +23,15 @@ func TestCreateOrApplyCertificates(t *testing.T) {
 		{
 			name: "reconciliation of certificate fails while checking if exists",
 			preReq: func(_ *Reconciler, m *fakes.FakeCtrlClient) {
-				m.GetCalls(func(_ context.Context, ns types.NamespacedName, obj client.Object) error {
+				m.GetCalls(func(_ context.Context, _ types.NamespacedName, obj client.Object) error {
 					switch o := obj.(type) {
 					case *v1alpha1.IstioCSR:
 						istiocsr := testIstioCSR()
 						istiocsr.DeepCopyInto(o)
 					}
 					return nil
 				})
-				m.ExistsCalls(func(_ context.Context, ns types.NamespacedName, obj client.Object) (bool, error) {
+				m.ExistsCalls(func(_ context.Context, _ types.NamespacedName, obj client.Object) (bool, error) {
 					switch obj.(type) {
 					case *certmanagerv1.Certificate:
 						return false, errTestClient
@@ -44,7 +44,7 @@ func TestCreateOrApplyCertificates(t *testing.T) {
 		{
 			name: "reconciliation of certificate fails while restoring to expected state",
 			preReq: func(_ *Reconciler, m *fakes.FakeCtrlClient) {
-				m.GetCalls(func(_ context.Context, ns types.NamespacedName, obj client.Object) error {
+				m.GetCalls(func(_ context.Context, _ types.NamespacedName, obj client.Object) error {
 					switch o := obj.(type) {
 					case *v1alpha1.IstioCSR:
 						istiocsr := testIstioCSR()

pkg/controller/trustmanager/serviceaccounts_test.go

@@ -81,8 +81,8 @@ func TestServiceAccountReconciliation(t *testing.T) {
 	}{
 		{
 			name: "successful apply when not found",
-			preReq: func(r *Reconciler, m *fakes.FakeCtrlClient) {
-				m.ExistsCalls(func(ctx context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
+			preReq: func(_ *Reconciler, m *fakes.FakeCtrlClient) {
+				m.ExistsCalls(func(_ context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
 					return false, nil
 				})
 			},
@@ -92,7 +92,7 @@ func TestServiceAccountReconciliation(t *testing.T) {
 		{
 			name: "skip apply when existing matches desired",
 			preReq: func(r *Reconciler, m *fakes.FakeCtrlClient) {
-				m.ExistsCalls(func(ctx context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
+				m.ExistsCalls(func(_ context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
 					sa := r.getServiceAccountObject(testResourceLabels(), testResourceAnnotations())
 					sa.DeepCopyInto(obj.(*corev1.ServiceAccount))
 					return true, nil
@@ -104,7 +104,7 @@ func TestServiceAccountReconciliation(t *testing.T) {
 		{
 			name: "apply when existing has label drift",
 			preReq: func(r *Reconciler, m *fakes.FakeCtrlClient) {
-				m.ExistsCalls(func(ctx context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
+				m.ExistsCalls(func(_ context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
 					sa := r.getServiceAccountObject(testResourceLabels(), testResourceAnnotations())
 					sa.Labels["app.kubernetes.io/instance"] = "modified-value"
 					sa.DeepCopyInto(obj.(*corev1.ServiceAccount))
@@ -144,7 +144,7 @@ func TestServiceAccountReconciliation(t *testing.T) {
 		},
 		{
 			name: "exists error propagates",
-			preReq: func(r *Reconciler, m *fakes.FakeCtrlClient) {
+			preReq: func(_ *Reconciler, m *fakes.FakeCtrlClient) {
 				m.ExistsCalls(func(ctx context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
 					return false, errTestClient
 				})
@@ -155,7 +155,7 @@ func TestServiceAccountReconciliation(t *testing.T) {
 		},
 		{
 			name: "patch error propagates",
-			preReq: func(r *Reconciler, m *fakes.FakeCtrlClient) {
+			preReq: func(_ *Reconciler, m *fakes.FakeCtrlClient) {
 				m.ExistsCalls(func(ctx context.Context, key client.ObjectKey, obj client.Object) (bool, error) {
 					return false, nil
 				})

pkg/operator/utils/apidiscovery_test.go

@@ -1,3 +1,4 @@
+//nolint:revive // utils is an established package name in this codebase
 package utils
 
 import (