Skip to content

Commit 85c89c5

Browse files
Merge pull request #402 from openshift-cherrypick-robot/cherry-pick-399-to-cert-manager-1.19
[cert-manager-1.19] CNF-22831: Fix typos in comments and test strings
2 parents f0996cf + 53052fe commit 85c89c5

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

pkg/controller/istiocsr/constants.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const (
7373
// will be of the form <istiocsr_namespace>/<istiocsr_instance-Name>.
7474
istiocsrResourceWatchLabelValueFmt = "%s_%s"
7575

76-
// IstiocsrCAConfigMapName is the name o the configmap which is mounted in istiocsr container, containing the
76+
// IstiocsrCAConfigMapName is the name of the configmap which is mounted in istiocsr container, containing the
7777
// CA certificate configured in the secret referenced in the issuer.
7878
IstiocsrCAConfigMapName = istiocsrCommonName + "-issuer-ca-copy"
7979

test/e2e/overrides_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
4747

4848
It("should add the args to the cert-manager controller deployment", func() {
4949

50-
By("Adding cert-manager controller override args to the cert-managaer operator object")
50+
By("Adding cert-manager controller override args to the cert-manager operator object")
5151
args := []string{
5252
// good-have to sync these args updated with the args present in
5353
// pkg/controller/deployment/deployment_overrides_validation.go,
@@ -88,7 +88,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
8888

8989
It("should add the args to the cert-manager webhook deployment", func() {
9090

91-
By("Adding cert-manager webhook override args to the cert-managaer operator object")
91+
By("Adding cert-manager webhook override args to the cert-manager operator object")
9292
args := []string{"--v=3"}
9393
err := addOverrideArgs(certmanageroperatorclient, certmanagerWebhookDeployment, args)
9494
Expect(err).NotTo(HaveOccurred())
@@ -109,7 +109,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
109109

110110
It("should add the args to the cert-manager cainjector deployment", func() {
111111

112-
By("Adding cert-manager cainjector override args to the cert-managaer operator object")
112+
By("Adding cert-manager cainjector override args to the cert-manager operator object")
113113
args := []string{"--v=3"}
114114
err := addOverrideArgs(certmanageroperatorclient, certmanagerCAinjectorDeployment, args)
115115
Expect(err).NotTo(HaveOccurred())
@@ -131,7 +131,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
131131

132132
It("should not add the args to the cert-manager controller deployment", func() {
133133

134-
By("Adding cert-manager controller override args to the cert-managaer operator object")
134+
By("Adding cert-manager controller override args to the cert-manager operator object")
135135
args := []string{"--invalid-args=foo"}
136136
err := addOverrideArgs(certmanageroperatorclient, certmanagerControllerDeployment, args)
137137
Expect(err).NotTo(HaveOccurred())
@@ -152,7 +152,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
152152

153153
It("should not add the args to the cert-manager webhook deployment", func() {
154154

155-
By("Adding cert-manager webhook override args to the cert-managaer operator object")
155+
By("Adding cert-manager webhook override args to the cert-manager operator object")
156156
args := []string{"--dns01-recursive-nameservers=10.10.10.10:53", "--dns01-recursive-nameservers-only", "--enable-certificate-owner-ref"}
157157
err := addOverrideArgs(certmanageroperatorclient, certmanagerWebhookDeployment, args)
158158
Expect(err).NotTo(HaveOccurred())
@@ -173,7 +173,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
173173

174174
It("should not add the args to the cert-manager cainjector deployment", func() {
175175

176-
By("Adding cert-manager cainjector override args to the cert-managaer operator object")
176+
By("Adding cert-manager cainjector override args to the cert-manager operator object")
177177
args := []string{"--dns01-recursive-nameservers=10.10.10.10:53", "--dns01-recursive-nameservers-only", "--enable-certificate-owner-ref"}
178178
err := addOverrideArgs(certmanageroperatorclient, certmanagerCAinjectorDeployment, args)
179179
Expect(err).NotTo(HaveOccurred())
@@ -563,7 +563,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
563563

564564
It("should add the env to the cert-manager controller deployment", func() {
565565

566-
By("Adding cert-manager controller override env to the cert-managaer operator object")
566+
By("Adding cert-manager controller override env to the cert-manager operator object")
567567
env := []corev1.EnvVar{{Name: "HTTP_PROXY", Value: "http://proxy.example.com:8080"}, {Name: "HTTPS_PROXY", Value: "http://proxy.example.com:8088"}, {Name: "NO_PROXY", Value: "localhost"}}
568568
err := addOverrideEnv(certmanageroperatorclient, certmanagerControllerDeployment, env)
569569
Expect(err).NotTo(HaveOccurred())
@@ -584,7 +584,7 @@ var _ = Describe("Overrides test", Ordered, Label("Platform:Generic"), func() {
584584

585585
It("should not add the env to the cert-manager controller deployment", func() {
586586

587-
By("Adding cert-manager controller override env to the cert-managaer operator object")
587+
By("Adding cert-manager controller override env to the cert-manager operator object")
588588
env := []corev1.EnvVar{{Name: "FOO", Value: "BAR"}}
589589
err := addOverrideEnv(certmanageroperatorclient, certmanagerControllerDeployment, env)
590590
Expect(err).NotTo(HaveOccurred())

0 commit comments

Comments
 (0)