context consistency: ensure all context are TODO()

Author: sebrandon1

pkg/controller/deployment/deploment_helper_test.go

@@ -334,7 +334,7 @@ func TestGetOverrideResourcesFor(t *testing.T) {
 		},
 	}
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.TODO())
 	defer cancel()
 
 	// Create channel to know when the watch has started.
@@ -856,7 +856,7 @@ func TestGetOverrideSchedulingFor(t *testing.T) {
 		},
 	}
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.TODO())
 	defer cancel()
 
 	// Create channel to know when the watch has started.

pkg/operator/informers/externalversions/factory.go

@@ -39,7 +39,7 @@ const (
 var testassets embed.FS
 
 func TestSelfSignedCerts(t *testing.T) {
-	ctx := context.Background()
+	ctx := context.TODO()
 	loader := library.NewDynamicResourceLoader(ctx, t)
 
 	ns, err := loader.CreateTestingNS("e2e-self-signed-cert")
@@ -68,7 +68,7 @@ func TestSelfSignedCerts(t *testing.T) {
 }
 
 func TestACMECertsIngress(t *testing.T) {
-	ctx := context.Background()
+	ctx := context.TODO()
 	loader := library.NewDynamicResourceLoader(ctx, t)
 	config, err := library.GetConfigForTest(t)
 	require.NoError(t, err)
@@ -154,7 +154,7 @@ func TestACMECertsIngress(t *testing.T) {
 }
 
 func TestCertRenew(t *testing.T) {
-	ctx := context.Background()
+	ctx := context.TODO()
 	loader := library.NewDynamicResourceLoader(ctx, t)
 	config, err := library.GetConfigForTest(t)
 	require.NoErrorf(t, err, "failed to fetch host configuration: %v", err)
@@ -307,7 +307,7 @@ func TestCertRenew(t *testing.T) {
 }
 
 func TestContainerOverrides(t *testing.T) {
-	ctx := context.Background()
+	ctx := context.TODO()
 	config, err := library.GetConfigForTest(t)
 	require.NoError(t, err)
 

test/e2e/cert_manager_deployment_test.go

@@ -40,7 +40,7 @@ var _ = Describe("ACME Certificate", Ordered, func() {
 
 	BeforeAll(func() {
 		By("creating Kube clients")
-		ctx = context.Background()
+		ctx = context.TODO()
 		var err error
 		baseDomain, err = library.GetClusterBaseDomain(ctx, configClient)
 		Expect(err).NotTo(HaveOccurred())
@@ -680,7 +680,7 @@ var _ = Describe("Self-signed Certificate", Ordered, func() {
 	var ns *corev1.Namespace
 
 	BeforeAll(func() {
-		ctx = context.Background()
+		ctx = context.TODO()
 
 		By("creating a test namespace")
 		namespace, err := loader.CreateTestingNS("e2e-self-signed-certs")

test/e2e/certificates_test.go

@@ -19,7 +19,7 @@ var _ = Describe("Overrides test", Ordered, func() {
 
 	BeforeEach(func() {
 		By("Reset cert-manager state")
-		err := resetCertManagerState(context.Background(), certmanageroperatorclient, loader)
+		err := resetCertManagerState(context.TODO(), certmanageroperatorclient, loader)
 		Expect(err).NotTo(HaveOccurred())
 
 		By("Waiting for operator status to become available")
@@ -492,7 +492,7 @@ var _ = Describe("Overrides test", Ordered, func() {
 
 	AfterAll(func() {
 		By("Reset cert-manager state")
-		err := resetCertManagerState(context.Background(), certmanageroperatorclient, loader)
+		err := resetCertManagerState(context.TODO(), certmanageroperatorclient, loader)
 		Expect(err).NotTo(HaveOccurred())
 
 		By("Waiting for operator status to become available")

test/e2e/overrides_test.go

@@ -322,7 +322,7 @@ func addOverrideScheduling(client *certmanoperatorclient.Clientset, deploymentNa
 // polling the deployment scheduling.
 func verifyDeploymentScheduling(k8sclient *kubernetes.Clientset, deploymentName string, res v1alpha1.CertManagerScheduling, added bool) error {
 
-	return wait.PollUntilContextTimeout(context.Background(), time.Second*10, time.Minute*5, true, func(context.Context) (done bool, err error) {
+	return wait.PollUntilContextTimeout(context.TODO(), time.Second*10, time.Minute*5, true, func(context.Context) (done bool, err error) {
 		controllerDeployment, err := k8sclient.AppsV1().Deployments(operandNamespace).Get(context.TODO(), deploymentName, v1.GetOptions{})
 		if err != nil {
 			if apierrors.IsNotFound(err) {

test/e2e/utils_test.go

@@ -31,7 +31,7 @@ func (d DynamicResourceLoader) CreateTestingNS(namespacePrefix string) (*v1.Name
 	var got *v1.Namespace
 	if err := wait.PollImmediate(1*time.Second, 30*time.Second, func() (bool, error) {
 		var err error
-		got, err = d.KubeClient.CoreV1().Namespaces().Create(context.Background(), namespace, metav1.CreateOptions{})
+		got, err = d.KubeClient.CoreV1().Namespaces().Create(context.TODO(), namespace, metav1.CreateOptions{})
 		if err != nil {
 			log.Printf("Error creating namespace: %v", err)
 			return false, nil
@@ -44,7 +44,7 @@ func (d DynamicResourceLoader) CreateTestingNS(namespacePrefix string) (*v1.Name
 }
 
 func (d DynamicResourceLoader) DeleteTestingNS(name string, shouldDumpEvents func() bool) (bool, error) {
-	ctx := context.Background()
+	ctx := context.TODO()
 	if shouldDumpEvents() {
 		d.DumpEventsInNamespace(name)
 	}