Skip to content

Commit 2b7b23c

Browse files
Merge pull request #2889 from mkowalski/OCPBUGS-74401
OCPBUGS-74401: Remove duplicated openssl parameter
2 parents f5b8490 + 756a7ea commit 2b7b23c

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

bindata/network/ovn-kubernetes/common/ipsec-containerized.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,19 @@ spec:
126126

127127
# Generate an SSL private key and use the key to create a certitificate signing request
128128
umask 077 && openssl genrsa -out /etc/openvswitch/keys/ipsec-privkey.pem 2048
129-
openssl req -new -text \
129+
if ! openssl req -new -text \
130130
-extensions v3_req \
131131
-addext "subjectAltName = DNS:${cn}" \
132132
-subj "/C=US/O=ovnkubernetes/OU=kind/CN=${cn}" \
133133
-key /etc/openvswitch/keys/ipsec-privkey.pem \
134-
-out /etc/openvswitch/keys/ipsec-req.pem
134+
-out /etc/openvswitch/keys/ipsec-req.pem; then
135+
echo "openssl req failed with -extensions v3_req, retrying without it"
136+
openssl req -new -text \
137+
-addext "subjectAltName = DNS:${cn}" \
138+
-subj "/C=US/O=ovnkubernetes/OU=kind/CN=${cn}" \
139+
-key /etc/openvswitch/keys/ipsec-privkey.pem \
140+
-out /etc/openvswitch/keys/ipsec-req.pem
141+
fi
135142

136143
csr_64=$(base64 -w0 /etc/openvswitch/keys/ipsec-req.pem) # -w0 to avoid line-wrap
137144

bindata/network/ovn-kubernetes/common/ipsec-host.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,19 @@ spec:
122122

123123
# Generate an SSL private key and use the key to create a certitificate signing request
124124
umask 077 && openssl genrsa -out /etc/openvswitch/keys/ipsec-privkey.pem 2048
125-
openssl req -new -text \
125+
if ! openssl req -new -text \
126126
-extensions v3_req \
127127
-addext "subjectAltName = DNS:${cn}" \
128128
-subj "/C=US/O=ovnkubernetes/OU=kind/CN=${cn}" \
129129
-key /etc/openvswitch/keys/ipsec-privkey.pem \
130-
-out /etc/openvswitch/keys/ipsec-req.pem
130+
-out /etc/openvswitch/keys/ipsec-req.pem; then
131+
echo "openssl req failed with -extensions v3_req, retrying without it"
132+
openssl req -new -text \
133+
-addext "subjectAltName = DNS:${cn}" \
134+
-subj "/C=US/O=ovnkubernetes/OU=kind/CN=${cn}" \
135+
-key /etc/openvswitch/keys/ipsec-privkey.pem \
136+
-out /etc/openvswitch/keys/ipsec-req.pem
137+
fi
131138

132139
csr_64=$(base64 -w0 /etc/openvswitch/keys/ipsec-req.pem) # -w0 to avoid line-wrap
133140

0 commit comments

Comments
 (0)