pkg/cvo: Respect empty desired log level

DavidHurta · DavidHurta · commit 07c50b1a2c9f · 2025-04-29T17:02:20.000+02:00
A desired log level in the ClusterVersionOperator object
can have an empty string value. Respect it, and treat
it as the Normal level.
diff --git a/pkg/cvo/configuration/configuration.go b/pkg/cvo/configuration/configuration.go
@@ -141,8 +141,12 @@ func (config *ClusterVersionOperatorConfiguration) sync(ctx context.Context, des
 			return fmt.Errorf("failed to update the ClusterVersionOperator resource: %w", err)
 		}
 	}
-	config.desiredLogLevel = desiredConfig.Spec.OperatorLogLevel
+
 	config.lastObservedGeneration = desiredConfig.Generation
+	config.desiredLogLevel = desiredConfig.Spec.OperatorLogLevel
+	if config.desiredLogLevel == "" {
+		config.desiredLogLevel = operatorv1.Normal
+	}
 
 	currentLogLevel, notFound := loglevel.GetLogLevel()
 	if notFound {

Original file line number	Diff line number	Diff line change
`@@ -141,8 +141,12 @@ func (config *ClusterVersionOperatorConfiguration) sync(ctx context.Context, des`
`141`	`141`	`return fmt.Errorf("failed to update the ClusterVersionOperator resource: %w", err)`
`142`	`142`	`}`
`143`	`143`	`}`
`144`		`- config.desiredLogLevel = desiredConfig.Spec.OperatorLogLevel`
	`144`	`+`
`145`	`145`	`config.lastObservedGeneration = desiredConfig.Generation`
	`146`	`+ config.desiredLogLevel = desiredConfig.Spec.OperatorLogLevel`
	`147`	`+ if config.desiredLogLevel == "" {`
	`148`	`+ config.desiredLogLevel = operatorv1.Normal`
	`149`	`+ }`
`146`	`150`
`147`	`151`	`currentLogLevel, notFound := loglevel.GetLogLevel()`
`148`	`152`	`if notFound {`