Skip to content

Commit f7e9723

Browse files
Merge pull request #1361 from jacobsee/waitForPodCompletion-discards-ListOptions
OCPBUGS-78997: Do not discard ListOptions in waitForPodCompletion.
2 parents 02f6e7b + c39ef75 commit f7e9723

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

pkg/cvo/updatepayload.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -373,11 +373,13 @@ func waitForPodCompletion(ctx context.Context, podListerWatcher PodListerWatcher
373373
_, err := toolswatch.UntilWithSync(
374374
ctx,
375375
&cache.ListWatch{
376-
ListFunc: func(options metav1.ListOptions) (object runtime.Object, e error) {
377-
return podListerWatcher.List(ctx, metav1.ListOptions{FieldSelector: fieldSelector})
376+
ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
377+
options.FieldSelector = fieldSelector
378+
return podListerWatcher.List(ctx, options)
378379
},
379380
WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) {
380-
return podListerWatcher.Watch(ctx, metav1.ListOptions{FieldSelector: fieldSelector})
381+
options.FieldSelector = fieldSelector
382+
return podListerWatcher.Watch(ctx, options)
381383
},
382384
},
383385
&corev1.Pod{},

0 commit comments

Comments
 (0)