Skip to content

Commit d810d26

Browse files
committed
Added [Serial] to serial e2e tests
1 parent d977735 commit d810d26

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

test/e2e/vsphere/machines.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:VSphereMultiDisk][platf
4646
Expect(err).NotTo(HaveOccurred())
4747
})
4848

49-
It("create machines with data disks [apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", func() {
49+
It("create machines with data disks [apigroup:machine.openshift.io][Serial][Suite:openshift/conformance/serial]", func() {
5050
machineName := "machine-multi-test"
5151
dataDisks := []v1beta1.VSphereDisk{
5252
{
@@ -166,28 +166,28 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:VSphereMultiDisk][platf
166166
err = mc.MachineSets(util.MachineAPINamespace).Delete(ctx, ddMachineSet.Name, metav1.DeleteOptions{})
167167
Expect(err).NotTo(HaveOccurred())
168168
},
169-
Entry("with thin data disk [apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", "ms-thin-test", []v1beta1.VSphereDisk{
169+
Entry("with thin data disk [apigroup:machine.openshift.io][Serial][Suite:openshift/conformance/serial]", "ms-thin-test", []v1beta1.VSphereDisk{
170170
{
171171
Name: "thickDataDisk",
172172
SizeGiB: 1,
173173
ProvisioningMode: v1beta1.ProvisioningModeThick,
174174
},
175175
}),
176-
Entry("with thick data disk [apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", "ms-thick-test", []v1beta1.VSphereDisk{
176+
Entry("with thick data disk [apigroup:machine.openshift.io][Serial][Suite:openshift/conformance/serial]", "ms-thick-test", []v1beta1.VSphereDisk{
177177
{
178178
Name: "thickDataDisk",
179179
SizeGiB: 1,
180180
ProvisioningMode: v1beta1.ProvisioningModeThick,
181181
},
182182
}),
183-
Entry("with eagerly zeroed data disk [apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", "ms-zeroed-test", []v1beta1.VSphereDisk{
183+
Entry("with eagerly zeroed data disk [apigroup:machine.openshift.io][Serial][Suite:openshift/conformance/serial]", "ms-zeroed-test", []v1beta1.VSphereDisk{
184184
{
185185
Name: "zeroedDataDisk",
186186
SizeGiB: 1,
187187
ProvisioningMode: v1beta1.ProvisioningModeEagerlyZeroed,
188188
},
189189
}),
190-
Entry("with a data disk using each provisioning mode [apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", "ms-multi-test", []v1beta1.VSphereDisk{
190+
Entry("with a data disk using each provisioning mode [apigroup:machine.openshift.io][Serial][Suite:openshift/conformance/serial]", "ms-multi-test", []v1beta1.VSphereDisk{
191191
{
192192
Name: "thinDataDisk",
193193
SizeGiB: 1,

test/e2e/vsphere/multi-nic.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2121
"k8s.io/client-go/kubernetes"
2222
"k8s.io/client-go/rest"
23+
"k8s.io/kubernetes/test/e2e/framework"
2324
e2e "k8s.io/kubernetes/test/e2e/framework"
2425
)
2526

@@ -129,8 +130,7 @@ func failIfMachinesDoNotHaveAllPortgroups(platformSpec configv1.PlatformSpec, ma
129130
}
130131

131132
func failIfMachineDoesNotHaveAllPortgroups(machine machinev1beta1.Machine, failureDomain configv1.VSpherePlatformFailureDomainSpec) {
132-
133-
By("checking to see if machine has all portgroups")
133+
framework.Logf("checking to see if machine %s has all portgroups", machine.Name)
134134

135135
spec, err := vsphere.ProviderSpecFromRawExtension(machine.Spec.ProviderSpec.Value)
136136
Expect(err).NotTo(HaveOccurred())
@@ -234,7 +234,7 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:VSphereMultiNetworks][p
234234
failIfIncorrectPortgroupsAttachedToVMs(ctx, infra, nodes, vsphereCreds)
235235
})
236236

237-
It("new machines should pass multi network tests [apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", Label("Serial"), func() {
237+
It("new machines should pass multi network tests [Serial][apigroup:machine.openshift.io][Suite:openshift/conformance/serial]", Label("Serial"), func() {
238238
machineSets, err := e2eutil.GetMachineSets(cfg)
239239
Expect(err).NotTo(HaveOccurred())
240240

0 commit comments

Comments
 (0)