Merge pull request #854 from DavidRajnoha/test/incident-detection-stability

NO-JIRA: Incident Detection Tests Stabilization

Author: openshift-merge-bot[bot]

web/cypress.config.ts

@@ -52,6 +52,7 @@ export default defineConfig({
     typeDelay: 200,
   },
   fixturesFolder: 'cypress/fixtures',
+  pageLoadTimeout: 60000,
   defaultCommandTimeout: 80000, //due to performance loading issue on console
   readyTimeoutMilliseconds: 120000,
   installTimeoutMilliseconds: 600000,

web/cypress/e2e/incidents/01.incidents.cy.ts

@@ -2,13 +2,11 @@
 The test verifies the basic functionality of the Incidents page and serves
 as a verification that the Incidents View is working as expected.
 
-Currently, it depends on an alert being present in the cluster.
-In the future, mocking requests / injecting alerts should be considered.
-Natural creation of the alert is done in the 00.coo_incidents_e2e.cy.ts test, 
-but takes significant time.
+All tests use mocked data. Tests 1-3 use a default fixture (incident content
+is irrelevant for toolbar/filter verification). Tests 4-5 switch mocks
+mid-test for empty state and traversal scenarios.
 */
 
-import { commonPages } from '../../views/common';
 import { incidentsPage } from '../../views/incidents-page';
 
 const MCP = {
@@ -26,24 +24,13 @@ const MP = {
   operatorName: 'Cluster Monitoring Operator',
 };
 
-const ALERTNAME = 'Watchdog';
-const NAMESPACE = 'openshift-monitoring';
-const SEVERITY = 'Critical';
-const ALERT_DESC = 'This is an alert meant to ensure that the entire alerting pipeline is functional. This alert is always firing, therefore it should always be firing in Alertmanager and always fire against a receiver. There are integrations with various notification mechanisms that send a notification when this alert is not firing. For example the "DeadMansSnitch" integration in PagerDuty.'
-const ALERT_SUMMARY = 'An alert that should always be firing to certify that Alertmanager is working properly.'
 describe('BVT: Incidents - UI', { tags: ['@smoke', '@incidents'] }, () => {
   before(() => {
     cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
+    cy.mockIncidentFixture('incident-scenarios/1-single-incident-firing-critical-and-warning-alerts.yaml');
   });
 
 
-  beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
-    // Temporary workaround for testing against locally built instances.
-    cy.transformMetrics();
-  });
-
   it('1. Admin perspective - Incidents page - Toolbar and charts toggle functionality', () => {
     cy.log('1.1 Verify toolbar and toggle charts button');
     incidentsPage.elements.toolbar().should('be.visible');
@@ -80,24 +67,23 @@ describe('BVT: Incidents - UI', { tags: ['@smoke', '@incidents'] }, () => {
     cy.log('4.1 Verify chart titles are visible');
     incidentsPage.elements.incidentsChartTitle().should('be.visible');
     incidentsPage.elements.alertsChartTitle().should('be.visible');
-    
     cy.log('4.2 Verify alerts chart shows empty state');
     incidentsPage.elements.alertsChartEmptyState().should('exist');
   });
 
   it('5. Admin perspective - Incidents page - Traverse Incident Table', () => {
+    incidentsPage.goTo();
+
     cy.log('5.1 Traverse incident table');
-    incidentsPage.clearAllFilters();
     cy.mockIncidents([]);
     incidentsPage.findIncidentWithAlert('TargetAlert').should('be.false');
 
     cy.log('5.2 Verify traversing incident table works when the alert is not present');
     cy.mockIncidentFixture('incident-scenarios/1-single-incident-firing-critical-and-warning-alerts.yaml');
     incidentsPage.findIncidentWithAlert('TargetAlert').should('be.false');
 
-    incidentsPage.clearAllFilters
     cy.log('5.3 Verify traversing incident table works when the alert is present');
     cy.mockIncidentFixture('incident-scenarios/6-multi-incident-target-alert-scenario.yaml');
-    incidentsPage.findIncidentWithAlert('TargetAlert').should('be.true');    
+    incidentsPage.findIncidentWithAlert('TargetAlert').should('be.true');
   });
 });

web/cypress/e2e/incidents/regression/01.reg_filtering.cy.ts

@@ -32,8 +32,6 @@ describe('Regression: Incidents Filtering', { tags: ['@incidents'] }, () => {
   });
 
   beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
     cy.log('Setting up comprehensive filtering test scenarios');
     cy.mockIncidentFixture('incident-scenarios/7-comprehensive-filtering-test-scenarios.yaml');
   });

web/cypress/e2e/incidents/regression/02.reg_ui_charts_comprehensive.cy.ts

@@ -92,7 +92,6 @@ describe('Regression: Charts UI - Comprehensive', { tags: ['@incidents'] }, () =
   });
 
   beforeEach(() => {
-    incidentsPage.goTo();
     cy.mockIncidentFixture('incident-scenarios/12-charts-ui-comprehensive.yaml');
   });
 

web/cypress/e2e/incidents/regression/03-04.reg_e2e_firing_alerts.cy.ts

@@ -36,11 +36,13 @@ const MP = {
 describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { tags: ['@incidents', '@slow', '@e2e-real'] }, () => {
   let currentAlertName: string;
 
+
   before(() => {
     cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
 
-    cy.log('Create or reuse firing alert for testing');
-    cy.createKubePodCrashLoopingAlert('TimeBasedResolution2').then((alertName) => {
+    cy.log('Create firing alert for testing');
+    cy.cleanupIncidentPrometheusRules();
+    cy.createKubePodCrashLoopingAlert().then((alertName) => {
       currentAlertName = alertName;
       cy.log(`Test will monitor alert: ${currentAlertName}`);
     });
@@ -50,6 +52,7 @@ describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { t
   it('1. Section 3.3 - Alert not incorrectly marked as resolved after time passes', () => {
     cy.log('1.1 Navigate to Incidents page and clear filters');
     incidentsPage.goTo();
+    cy.wait(10000);
     incidentsPage.clearAllFilters();
 
     const intervalMs = 60_000;
@@ -161,6 +164,7 @@ describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { t
   it('2. Section 4.7 - Prometheus query end time updates to current time on filter refresh', () => {
     cy.log('2.1 Navigate to Incidents page and clear filters');
     incidentsPage.goTo();
+    cy.wait(10000);
     incidentsPage.clearAllFilters();
 
     cy.log('2.2 Capture initial page load time');
@@ -262,6 +266,7 @@ describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { t
   it('3. Verify alert lifecycle - alert continues firing throughout test', () => {
     cy.log('3.1 Navigate to Incidents page');
     incidentsPage.goTo();
+    cy.wait(10000);
     incidentsPage.clearAllFilters();
 
     cy.log('3.2 Search for and select incident with custom alert');

web/cypress/e2e/incidents/regression/03.reg_api_calls.cy.ts

@@ -33,8 +33,6 @@ describe('Regression: Silences Not Applied Correctly', { tags: ['@incidents'] },
   });
 
   beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
     cy.log('Setting up silenced alerts mixed scenario');
     cy.mockIncidentFixture('incident-scenarios/9-silenced-alerts-mixed-scenario.yaml');
   });

web/cypress/e2e/incidents/regression/04.reg_redux_effects.cy.ts

@@ -37,8 +37,6 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
   });
 
   beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
     cy.log('Setting up comprehensive filtering test scenarios');
     cy.mockIncidentFixture('incident-scenarios/7-comprehensive-filtering-test-scenarios.yaml');
   });
@@ -144,10 +142,8 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
   it('3. Adding filter when incident selected should not remove the incident ID filter', () => {
     cy.log('3.1 Clear all filters and ensure critical incidents exist');
     incidentsPage.clearAllFilters();
-    
     cy.log('3.2 Apply critical severity filter');
     incidentsPage.toggleFilter('Critical');
-    
     incidentsPage.elements.incidentsChartBarsGroups().should('have.length.greaterThan', 0);
 
     cy.log('3.3 Click on the first critical incident to select it by ID');
@@ -161,9 +157,12 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
     cy.log('3.5 Verify both Critical and Incident ID chips are present');
     incidentsPage.elements.filterChipValue('Critical').should('be.visible');
     incidentsPage.elements.incidentIdFilterChip().should('be.visible');
-    
+  
     cy.log('3.6 Deselect Critical and Apply Warning filter (which does not match the critical incident)');
+    cy.wait(500);
     incidentsPage.toggleFilter('Critical');
+    incidentsPage.elements.filterChipValue('Critical').should('not.exist');
+
     incidentsPage.toggleFilter('Warning');
 
     cy.log('3.7 Verify incident is filtered out (no bars visible)');
@@ -177,7 +176,9 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
     cy.log('SUCCESS: Incident ID filter was not removed when non-matching severity filter was added');
 
     cy.log('3.9 Remove Warning filter and verify incident reappears');
-    incidentsPage.toggleFilter('Warning');
+    // Legacy path for quick rollback:
+    // incidentsPage.toggleFilter('Warning');
+    incidentsPage.deselectFilterValue('Warning');
 
     cy.log('3.10 With only Incident ID filter, incident should be visible again');
     incidentsPage.elements.incidentsChartBarsGroups().should('have.length', 1);

web/cypress/support/incidents_prometheus_query_mocks/prometheus-mocks.ts

@@ -1,6 +1,7 @@
 import { IncidentDefinition, PrometheusResponse, IncidentScenarioFixture } from './types';
 import { createIncidentMock, createAlertDetailsMock } from './mock-generators';
 import { convertFixtureToIncidents, parseYamlFixture } from './schema/fixture-converter';
+import { incidentsPage } from '../../views/incidents-page';
 
 declare global {
   namespace Cypress {
@@ -63,9 +64,15 @@ export function mockPrometheusQueryRange(incidents: IncidentDefinition[]): void
       console.log(`Responding with ${results.length} incident alerts from ${incidents.length} incidents`);
       req.reply(response);
 
-  });
+  }).as('prometheusQueryMock');
 }
 
+/**
+ * Mock commands: register intercepts and navigate via goTo() to trigger a fresh data fetch.
+ * Using SPA navigation instead of cy.reload() avoids the dynamic-plugin chunk loading
+ * race condition that causes flaky empty-page failures in headless CI.
+ */
+
 Cypress.Commands.add('mockIncidents', (incidents: IncidentDefinition[]) => {
   cy.log(`=== SETTING UP INCIDENT MOCKING (${incidents.length} incidents) ===`);
   if (!Array.isArray(incidents)) {
@@ -81,8 +88,7 @@ Cypress.Commands.add('mockIncidents', (incidents: IncidentDefinition[]) => {
 
   cy.log(`=== SETTING UP INCIDENT MOCKING (${incidents.length} incidents) ===`);
   mockPrometheusQueryRange(incidents);
-  // The mocking is not applied until the page is reloaded and the components fetch the new data
-  cy.reload();
+  incidentsPage.goTo();
 });
 
 Cypress.Commands.add('mockIncidentFixture', (fixturePath: string) => {
@@ -101,9 +107,8 @@ Cypress.Commands.add('mockIncidentFixture', (fixturePath: string) => {
     });
   }
 
-
-  // The mocking is not applied until the page is reloaded and the components fetch the new data
-  cy.reload();
+  incidentsPage.goTo();
+  cy.wait('@prometheusQueryMock', { timeout: 30000 });
 });
 
 Cypress.Commands.add('transformMetrics', () => {