Skip to content

Commit ca5f2eb

Browse files
committed
Cherry-pick perses fixes from etmura-perses-fix
Brings navigation workarounds, dropdown assertion ordering, step numbering fixes, and cancel button wait from etmura-perses-fix. Made-with: Cursor
1 parent fc20b7d commit ca5f2eb

11 files changed

Lines changed: 20 additions & 11 deletions

web/cypress/e2e/perses/99.coo_rbac_perses_user1.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('RBAC User1: COO - Dashboards (Perses) - Administrator perspective', {
6363
});
6464

6565
beforeEach(() => {
66+
nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
6667
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
6768
});
6869

web/cypress/e2e/perses/99.coo_rbac_perses_user2.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('RBAC User2: COO - Dashboards (Perses) - Administrator perspective', {
6363
});
6464

6565
beforeEach(() => {
66+
nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
6667
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
6768
cy.changeNamespace('All Projects');
6869
});

web/cypress/e2e/perses/99.coo_rbac_perses_user3.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('RBAC User3: COO - Dashboards (Perses) - Administrator perspective', {
6363
});
6464

6565
beforeEach(() => {
66+
nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
6667
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
6768
});
6869

web/cypress/e2e/perses/99.coo_rbac_perses_user4.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('RBAC User4: COO - Dashboards (Perses) - Administrator perspective', {
6363
});
6464

6565
beforeEach(() => {
66+
nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
6667
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
6768
});
6869

web/cypress/e2e/perses/99.coo_rbac_perses_user5.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('RBAC User5: COO - Dashboards (Perses) - Administrator perspective', {
6363
});
6464

6565
beforeEach(() => {
66+
nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
6667
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
6768
});
6869

web/cypress/e2e/perses/99.coo_rbac_perses_user6.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('RBAC User6: COO - Dashboards (Perses) - Administrator perspective', {
6363
});
6464

6565
beforeEach(() => {
66+
nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
6667
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
6768
});
6869

web/cypress/support/perses/01.coo_list_perses_admin_namespace.cy.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { persesDashboardsDashboardDropdownCOO, persesDashboardsDashboardDropdown
22
import { commonPages } from '../../views/common';
33
import { listPersesDashboardsPage } from "../../views/perses-dashboards-list-dashboards";
44
import { persesDashboardsPage } from '../../views/perses-dashboards';
5+
import { nav } from '../../views/nav';
56

67
export interface PerspectiveConfig {
78
name: string;
@@ -69,10 +70,10 @@ export function testCOOListPersesNamespace(perspective: PerspectiveConfig) {
6970
listPersesDashboardsPage.emptyState();
7071
listPersesDashboardsPage.countDashboards('0');
7172

72-
cy.log(`1.11. Clear all filters`);
73-
listPersesDashboardsPage.clearAllFilters();
73+
nav.sidenav.clickNavLink(['Observe', 'Alerting']);
74+
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
7475

75-
cy.log(`1.12. Click on a dashboard`);
76+
cy.log(`1.11. Click on a dashboard`);
7677
listPersesDashboardsPage.clickDashboard(persesDashboardsDashboardDropdownCOO.APM_DASHBOARD[0]);
7778
//TODO: change back to shouldBeLoaded when customizable-dashboards gets merged
7879
persesDashboardsPage.shouldBeLoaded1();
@@ -121,8 +122,8 @@ export function testCOOListPersesNamespace(perspective: PerspectiveConfig) {
121122
listPersesDashboardsPage.countDashboards('0');
122123

123124
cy.log(`2.7. Search for the renamed dashboard`);
124-
listPersesDashboardsPage.clearAllFilters();
125-
cy.changeNamespace('All Projects');
125+
nav.sidenav.clickNavLink(['Observe', 'Alerting']);
126+
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
126127
listPersesDashboardsPage.filter.byName(persesDashboardsDashboardDropdownPersesDev.PERSES_DASHBOARD_SAMPLE[0] + ' - Renamed');
127128
listPersesDashboardsPage.countDashboards('0');
128129
listPersesDashboardsPage.clearAllFilters();

web/cypress/support/perses/99.coo_rbac_perses_user1.cy.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,11 +476,11 @@ export function testCOORBACPersesTestsDevUser1(perspective: PerspectiveConfig) {
476476
cy.log(`9.1. use sidebar nav to go to Observe > Dashboards (Perses)`);
477477
listPersesDashboardsPage.shouldBeLoaded();
478478

479-
cy.log(`9.3. Filter by Name`);
479+
cy.log(`9.2. Filter by Name`);
480480
listPersesDashboardsPage.filter.byName('Testing Dashboard - UP');
481481
listPersesDashboardsPage.countDashboards('1');
482482

483-
cy.log(`9.4. Click on the Kebab icon - Delete`);
483+
cy.log(`9.3. Click on the Kebab icon - Delete`);
484484
listPersesDashboardsPage.clickKebabIcon();
485485
listPersesDashboardsPage.clickDeleteOption();
486486
listPersesDashboardsPage.deleteDashboardDeleteButton();
@@ -489,7 +489,7 @@ export function testCOORBACPersesTestsDevUser1(perspective: PerspectiveConfig) {
489489
nav.sidenav.clickNavLink(['Observe', 'Alerting']);
490490
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
491491

492-
cy.log(`9.5. Filter by Name`);
492+
cy.log(`9.4. Filter by Name`);
493493
listPersesDashboardsPage.filter.byName('Testing Dashboard - UP');
494494
listPersesDashboardsPage.countDashboards('0');
495495
nav.sidenav.clickNavLink(['Observe', 'Alerting']);
@@ -511,7 +511,7 @@ export function testCOORBACPersesTestsDevUser1(perspective: PerspectiveConfig) {
511511
persesImportDashboardsPage.uploadFile('./cypress/fixtures/coo/coo141_perses/import/testing-perses-dashboard.json');
512512
persesImportDashboardsPage.assertPersesDashboardDetected();
513513

514-
cy.log(`10.4. Verify project dropdown options`);
514+
cy.log(`10.4. Verify project dropdown options`);
515515
persesImportDashboardsPage.assertProjectNotExistsInDropdown('observ-test');
516516
persesImportDashboardsPage.assertProjectNotExistsInDropdown('perses-dev');
517517
persesImportDashboardsPage.assertProjectNotExistsInDropdown('openshift-monitoring');

web/cypress/support/perses/99.coo_rbac_perses_user3.cy.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,13 @@ export function testCOORBACPersesTestsDevUser3(perspective: PerspectiveConfig) {
6262
listPersesDashboardsPage.assertCreateButtonIsEnabled();
6363
listPersesDashboardsPage.clickCreateButton();
6464
persesCreateDashboardsPage.createDashboardShouldBeLoaded();
65-
persesCreateDashboardsPage.assertProjectDropdown('empty-namespace3');
6665
persesCreateDashboardsPage.assertProjectNotExistsInDropdown('openshift-cluster-observability-operator');
6766
persesCreateDashboardsPage.assertProjectNotExistsInDropdown('observ-test');
6867
persesCreateDashboardsPage.assertProjectNotExistsInDropdown('perses-dev');
6968
persesCreateDashboardsPage.assertProjectNotExistsInDropdown('openshift-monitoring');
7069
persesCreateDashboardsPage.assertProjectNotExistsInDropdown('empty-namespace4');
70+
persesCreateDashboardsPage.assertProjectDropdown('empty-namespace3');
71+
7172
persesCreateDashboardsPage.createDashboardDialogCancelButton();
7273

7374
cy.log(`1.4. openshift-monitoring validation - Dashboard search - empty state`);

web/cypress/support/perses/99.coo_rbac_perses_user5.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ export function testCOORBACPersesTestsDevUser5(perspective: PerspectiveConfig) {
341341
persesImportDashboardsPage.uploadFile('./cypress/fixtures/coo/coo141_perses/import/testing-perses-dashboard.json');
342342
persesImportDashboardsPage.assertPersesDashboardDetected();
343343

344-
cy.log(`7.4. Verify project dropdown options`);
344+
cy.log(`7.4. Verify project dropdown options`);
345345
persesImportDashboardsPage.assertProjectNotExistsInDropdown('openshift-cluster-observability-operator');
346346
persesImportDashboardsPage.assertProjectNotExistsInDropdown('empty-namespace3');
347347
persesImportDashboardsPage.assertProjectNotExistsInDropdown('observ-test');

0 commit comments

Comments
 (0)