Skip to content

Commit 1d1f6f6

Browse files
Merge pull request #57 from bradmwilliams/formatting_cleanup
Code cleanup
2 parents a60a176 + 473e0d5 commit 1d1f6f6

19 files changed

Lines changed: 99 additions & 64 deletions

ansible/rebuild_module.digest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3cc90352c787fb2a66626b33f149e1f9 -
1+
14fd6a307ac3c1c78d0a1e69452ae072 -

ansible/roles/openshift_client_python/library/openshift_client_python.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/openshift/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from __future__ import absolute_import
2+
23
from .context import *
34
from .base_verbs import *
45
from .model import OpenShiftPythonException

packages/openshift/action.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from __future__ import absolute_import
2+
23
import subprocess
34
import time
45
import socket
@@ -7,9 +8,10 @@
78
import re
89
import datetime
910
import traceback
11+
import six
1012

1113
from .util import TempFile, is_collection_type
12-
import six
14+
1315

1416
# Three base64 encoded components, '.' delimited is a token. First, find any such match.
1517
# You can find examples of these tokens with `oc sa get-token <serviceaccount name>`

packages/openshift/apiobject.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
from __future__ import absolute_import
2+
3+
import yaml
4+
import sys
5+
import copy
6+
27
from .action import *
38
from .model import *
49
from .result import *
510
from .naming import kind_matches
11+
from .context import cur_context
12+
from .selector import selector
613
from . import util
7-
import yaml
8-
import json
9-
import sys
10-
import copy
11-
from six.moves import range
1214

1315
_DEFAULT = object()
1416

@@ -483,7 +485,7 @@ def modify_and_apply(self, modifier_func, retries=2, cmd_args=None):
483485
"""
484486
r = Result("apply")
485487

486-
applied_change = False;
488+
applied_change = False
487489
for attempt in reversed(list(range(retries + 1))):
488490

489491
do_apply = modifier_func(self)
@@ -877,7 +879,3 @@ def execute(self, cmd_to_exec=None, stdin=None, container_name=None, auto_raise=
877879
r.fail_if(
878880
"Error running {} exec on {} [rc={}]: {}".format(self.qname(), cmd_to_exec[0], r.status(), r.err()))
879881
return r
880-
881-
882-
from .context import cur_context
883-
from .selector import selector

packages/openshift/base_verbs.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,6 @@
22
from __future__ import absolute_import
33

44
import os
5-
from .selector import Selector, selector
6-
from .action import oc_action
7-
from .context import cur_context, project, no_tracking
8-
from .result import Result
9-
from .apiobject import APIObject
10-
from .model import Model, Missing, OpenShiftPythonException
11-
from . import util
12-
from . import naming
135
import base64
146
import io
157
import sys
@@ -19,6 +11,15 @@
1911
import yaml
2012
import six
2113

14+
from .selector import Selector, selector
15+
from .action import oc_action
16+
from .context import cur_context, project, no_tracking
17+
from .result import Result
18+
from .apiobject import APIObject
19+
from .model import Model, Missing, OpenShiftPythonException
20+
from . import util
21+
from . import naming
22+
2223

2324
def eprint(*args, **kwargs):
2425
print(*args, file=sys.stderr, **kwargs)

packages/openshift/config.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
#!/usr/bin/python
2-
31
from __future__ import absolute_import
2+
43
import openshift as oc
54
import base64
65
import json

packages/openshift/context.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
from __future__ import absolute_import
2+
3+
import inspect
4+
import os
5+
26
from datetime import datetime
37
from datetime import timedelta
48
from threading import local
5-
import inspect
6-
7-
import os
89

910
from .result import Result
1011

packages/openshift/model.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from __future__ import absolute_import
2+
23
import six
4+
35
from six.moves import range
46

57

@@ -111,7 +113,7 @@ def to_model_or_val(v, case_insensitive=False):
111113
return v
112114

113115

114-
def _element_can_match( master, test, case_insensitive=False):
116+
def _element_can_match(master, test, case_insensitive=False):
115117
if master is Missing:
116118
return False
117119

packages/openshift/naming.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from __future__ import absolute_import
2+
23
import six
34

45
# A dict of name -> APIResource.
@@ -231,6 +232,7 @@ def get_column_value(line, column_name):
231232
except StopIteration:
232233
break
233234

235+
234236
# just paste the output of `oc api-resources --verbs=get` in this variable (including header!).
235237
# It will be processed on startup. this could eventually be replaced with
236238
# calls to --raw 'api/v1', 'apis/..../v1'.. etc, but let oc do the work for us.

0 commit comments

Comments
 (0)