Skip to content

Commit 8e05ea1

Browse files
Merge pull request #64 from bradmwilliams/python3-encoding-decoding-fix
Fixing python3 porting issue (json.dumps - encoding) and adding unit …
2 parents d1d0920 + 545c2f3 commit 8e05ea1

5 files changed

Lines changed: 22 additions & 4 deletions

File tree

ansible/rebuild_module.digest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b83aa8bbbe8013e359486160af686bbf -
1+
5eb4a318eecb23a689b2ce1239f9f2d9 -

ansible/roles/openshift_client_python/library/openshift_client_python.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/openshift/apiobject.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def as_json(self, indent=4):
116116
"""
117117
:return: Returns a JSON presentation of the APIObject.
118118
"""
119-
return json.dumps(self.model._primitive(), indent=indent, encoding='utf-8').strip().decode('utf-8')
119+
return json.dumps(self.model._primitive(), indent=indent).strip()
120120

121121
def kind(self, lowercase=True, if_missing=_DEFAULT):
122122
"""
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import unittest
2+
3+
from .apiobject import APIObject
4+
5+
6+
class TestModel(unittest.TestCase):
7+
8+
def test_empty(self):
9+
obj = APIObject()
10+
self.assertIs(len(obj.model), 0)
11+
self.assertEqual(obj.as_dict(), {})
12+
self.assertEqual(obj.as_json(), '{}')
13+
self.assertIsNone(obj.context.project_name)
14+
15+
16+
if __name__ == '__main__':
17+
unittest.main()

run_unittests.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22

33
export PYTHONPATH="$(pwd)/packages"
44
cd $(pwd)/packages
5-
python -m unittest discover
5+
python2 -m unittest discover
6+
python3 -m unittest discover

0 commit comments

Comments
 (0)