Skip to content

Commit ebdabb6

Browse files
committed
add new dcm e2e tests
Add DCM e2e tests focused on user experience. Here are some requisites and thoughts kept in mind while designing and coding the tests: * Document what the test should do and its expectations. * Make it as much focused on user experience as possible: create the scenarios and validate the result checking the behavior in the same way the user would observe it. * Make it more declarative: create the pre-requisite for the test inside the test itself, instead of relying on pre-configured requisites. * Make it simple to follow: try to abstract complexities into higher level calls, making the test itself smaller, but also comprehensive. https://redhat.atlassian.net/browse/NE-2529
1 parent 394edfe commit ebdabb6

2 files changed

Lines changed: 577 additions & 1 deletion

File tree

test/extended/router/config_manager.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ import (
3131

3232
const timeoutSeconds = 3 * 60
3333

34+
const routerSelectorKey = "select"
35+
const routerSelectorValue = "haproxy-cfgmgr"
36+
3437
var _ = g.Describe("[sig-network][Feature:Router][apigroup:route.openshift.io]", func() {
3538
defer g.GinkgoRecover()
3639
var (
@@ -846,7 +849,7 @@ func createRoute(oc *exutil.CLI, routeType routeType, routeName, serviceName, ho
846849
if err != nil {
847850
return err
848851
}
849-
return oc.AsAdmin().Run("label").Args("route", routeName, "select=haproxy-cfgmgr").Execute()
852+
return oc.AsAdmin().Run("label").Args("route", routeName, routerSelectorKey+"="+routerSelectorValue).Execute()
850853
}
851854

852855
func readURL(ns, execPodName, host, abspath, ipaddr string) (string, error) {

0 commit comments

Comments
 (0)