Skip to content

Commit a03a13a

Browse files
Merge pull request #728 from bradmwilliams/ocp-5-prefix-fix
Fixing release-5 prefix bug for OCP 5.0
2 parents 74028a7 + 92e7977 commit a03a13a

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

cmd/release-controller/sync_verify.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ func (c *Controller) resolveUpgradeRelease(upgradeRelease *releasecontroller.Upg
220220
} else if upgradeRelease.Candidate != nil {
221221
// create blank semver.Range
222222
var constraint semver.Range
223-
stream := fmt.Sprintf("%s.0-0.%s%s", upgradeRelease.Candidate.Version, upgradeRelease.Candidate.Stream, strings.TrimPrefix(release.Config.To, "release"))
223+
stream := fmt.Sprintf("%s.0-0.%s%s", upgradeRelease.Candidate.Version, upgradeRelease.Candidate.Stream, TrimPrefixes(release.Config.To, "release-5", "release"))
224224
r, latest, err := releasecontroller.LatestForStream(c.parsedReleaseConfigCache, c.eventRecorder, c.releaseLister, stream, constraint, upgradeRelease.Candidate.Relative, "")
225225
if err != nil {
226226
return "", "", fmt.Errorf("failed to get latest tag for stream %s: %w", stream, err)
@@ -239,3 +239,12 @@ func (c *Controller) resolveUpgradeRelease(upgradeRelease *releasecontroller.Upg
239239
}
240240
return "", "", fmt.Errorf("upgradeRelease fields must be set if upgradeRelease is set")
241241
}
242+
243+
func TrimPrefixes(s string, prefixes ...string) string {
244+
for _, prefix := range prefixes {
245+
if after, found := strings.CutPrefix(s, prefix); found {
246+
return after
247+
}
248+
}
249+
return s
250+
}

0 commit comments

Comments
 (0)