Skip to content

Commit 6a09268

Browse files
Merge pull request #632 from openshift-cherrypick-robot/cherry-pick-626-to-release-4.12
[release-4.12] OCPBUGS-43703: add duplicate_te_header_total metric
2 parents 29b4ae9 + c3f150f commit 6a09268

2 files changed

Lines changed: 122 additions & 93 deletions

File tree

pkg/router/metrics/haproxy/haproxy.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,11 @@ type counterValuesByMetric map[metricID][]int64
108108

109109
// defaultSelectedMetrics is the list of metrics included by default. These metrics are a subset
110110
// of the metrics exposed by haproxy_exporter by default for performance reasons.
111-
var defaultSelectedMetrics = []int{2, 4, 5, 7, 8, 9, 13, 14, 17, 21, 24, 33, 35, 39, 40, 41, 42, 43, 44, 58, 59, 60, 79, 85}
111+
var defaultSelectedMetrics = []int{2, 4, 5, 7, 8, 9, 13, 14, 17, 21, 24, 33, 35, 39, 40, 41, 42, 43, 44, 58, 59, 60, 79, 85, 99}
112112

113113
// defaultCounterMetrics is the list of metrics that are counters and should be preserved across
114114
// restarts. Only add metrics to this list if they are a counter.
115-
var defaultCounterMetrics = []int{7, 8, 9, 13, 14, 21, 24, 39, 40, 41, 42, 43, 44, 79, 85}
115+
var defaultCounterMetrics = []int{7, 8, 9, 13, 14, 21, 24, 39, 40, 41, 42, 43, 44, 79, 85, 99}
116116

117117
// Exporter collects HAProxy stats from the given URI and exports them using
118118
// the prometheus metrics package.
@@ -266,6 +266,7 @@ func NewExporter(opts PrometheusOptions) (*Exporter, error) {
266266
59: newBackendMetric("http_average_connect_latency_milliseconds", "Average connect latency of the last 1024 requests in milliseconds.", nil),
267267
60: newBackendMetric("http_average_response_latency_milliseconds", "Average response latency of the last 1024 requests in milliseconds.", nil),
268268
85: newBackendMetric("connections_reused_total", "Total number of connections reused.", nil),
269+
99: newBackendMetric("duplicate_te_header_total", "Total number of duplicate Transfer-Encoding headers detected", nil),
269270
}),
270271
serverMetrics: filterMetrics(opts.ExportedMetrics, metrics{
271272
2: newServerMetric("current_queue", "Current number of queued requests assigned to this server.", nil),

0 commit comments

Comments
 (0)