Skip to content

Commit 8247689

Browse files
ThomasLeykimphil
authored andcommitted
DEM UART: Acknowledge access to unimplemented regs
1 parent cc98c62 commit 8247689

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

modules/dem_uart/common/osd_dem_uart_16550.sv

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ module osd_dem_uart_16550
5151
localparam REG_IIR_FCR = 2;
5252
localparam REG_LCR = 3;
5353
localparam REG_LSR = 5;
54-
localparam REG_SCR = 7;
5554

5655
// Interrupt identification codes as per the UART 16550 specification
5756
localparam INTR_NONE = 4'b0001;
@@ -127,7 +126,7 @@ module osd_dem_uart_16550
127126
nxt_fifo_tx_clear = fifo_tx_clear;
128127
nxt_dma_mode = dma_mode;
129128
nxt_lcr = lcr;
130-
129+
131130
out_char = 8'h0;
132131
out_valid = 1'b0;
133132
in_ready = 1'b0;
@@ -205,6 +204,10 @@ module osd_dem_uart_16550
205204
bus_rdata = {7'b0110000, in_valid};
206205
bus_ack = bus_req;
207206
end
207+
default: begin
208+
// Not acknowledging access to unimplemented registers could hang the bus.
209+
bus_ack = bus_req;
210+
end
208211
endcase
209212
end // if (req)
210213

0 commit comments

Comments
 (0)