|
| 1 | +package v1beta1 |
| 2 | + |
| 3 | +import ( |
| 4 | + . "github.com/onsi/ginkgo/v2" |
| 5 | + . "github.com/onsi/gomega" |
| 6 | + rabbitmqv1 "github.com/openstack-k8s-operators/infra-operator/apis/rabbitmq/v1beta1" |
| 7 | + "k8s.io/apimachinery/pkg/util/validation/field" |
| 8 | +) |
| 9 | + |
| 10 | +var _ = Describe("OpenStackControlPlane Webhook", func() { |
| 11 | + |
| 12 | + Context("ValidateMessagingBusConfig", func() { |
| 13 | + var instance *OpenStackControlPlane |
| 14 | + var basePath *field.Path |
| 15 | + |
| 16 | + BeforeEach(func() { |
| 17 | + instance = &OpenStackControlPlane{ |
| 18 | + Spec: OpenStackControlPlaneSpec{}, |
| 19 | + } |
| 20 | + basePath = field.NewPath("spec") |
| 21 | + }) |
| 22 | + |
| 23 | + It("should allow only Cluster field in messagingBus", func() { |
| 24 | + instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{ |
| 25 | + Cluster: "rabbitmq", |
| 26 | + } |
| 27 | + |
| 28 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 29 | + Expect(errs).To(BeEmpty()) |
| 30 | + }) |
| 31 | + |
| 32 | + It("should allow Cluster and Vhost fields in messagingBus", func() { |
| 33 | + instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{ |
| 34 | + Cluster: "rabbitmq", |
| 35 | + Vhost: "/openstack", |
| 36 | + } |
| 37 | + |
| 38 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 39 | + Expect(errs).To(BeEmpty()) |
| 40 | + }) |
| 41 | + |
| 42 | + It("should reject User field in messagingBus", func() { |
| 43 | + instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{ |
| 44 | + Cluster: "rabbitmq", |
| 45 | + User: "shared-user", |
| 46 | + } |
| 47 | + |
| 48 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 49 | + Expect(errs).To(HaveLen(1)) |
| 50 | + Expect(errs[0].Type).To(Equal(field.ErrorTypeForbidden)) |
| 51 | + Expect(errs[0].Field).To(Equal("spec.messagingBus.user")) |
| 52 | + Expect(errs[0].Detail).To(ContainSubstring("user field is not allowed at the top level")) |
| 53 | + }) |
| 54 | + |
| 55 | + It("should reject User field even with other valid fields in messagingBus", func() { |
| 56 | + instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{ |
| 57 | + Cluster: "rabbitmq", |
| 58 | + Vhost: "/openstack", |
| 59 | + User: "shared-user", |
| 60 | + } |
| 61 | + |
| 62 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 63 | + Expect(errs).To(HaveLen(1)) |
| 64 | + Expect(errs[0].Type).To(Equal(field.ErrorTypeForbidden)) |
| 65 | + Expect(errs[0].Field).To(Equal("spec.messagingBus.user")) |
| 66 | + }) |
| 67 | + |
| 68 | + It("should allow only Cluster field in notificationsBus", func() { |
| 69 | + instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{ |
| 70 | + Cluster: "rabbitmq-notifications", |
| 71 | + } |
| 72 | + |
| 73 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 74 | + Expect(errs).To(BeEmpty()) |
| 75 | + }) |
| 76 | + |
| 77 | + It("should allow Cluster and Vhost fields in notificationsBus", func() { |
| 78 | + instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{ |
| 79 | + Cluster: "rabbitmq-notifications", |
| 80 | + Vhost: "/notifications", |
| 81 | + } |
| 82 | + |
| 83 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 84 | + Expect(errs).To(BeEmpty()) |
| 85 | + }) |
| 86 | + |
| 87 | + It("should reject User field in notificationsBus", func() { |
| 88 | + instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{ |
| 89 | + Cluster: "rabbitmq-notifications", |
| 90 | + User: "shared-user", |
| 91 | + } |
| 92 | + |
| 93 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 94 | + Expect(errs).To(HaveLen(1)) |
| 95 | + Expect(errs[0].Type).To(Equal(field.ErrorTypeForbidden)) |
| 96 | + Expect(errs[0].Field).To(Equal("spec.notificationsBus.user")) |
| 97 | + Expect(errs[0].Detail).To(ContainSubstring("user field is not allowed at the top level")) |
| 98 | + }) |
| 99 | + |
| 100 | + It("should reject User field in both messagingBus and notificationsBus", func() { |
| 101 | + instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{ |
| 102 | + Cluster: "rabbitmq", |
| 103 | + User: "rpc-user", |
| 104 | + } |
| 105 | + instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{ |
| 106 | + Cluster: "rabbitmq-notifications", |
| 107 | + User: "notif-user", |
| 108 | + } |
| 109 | + |
| 110 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 111 | + Expect(errs).To(HaveLen(2)) |
| 112 | + Expect(errs[0].Field).To(Equal("spec.messagingBus.user")) |
| 113 | + Expect(errs[1].Field).To(Equal("spec.notificationsBus.user")) |
| 114 | + }) |
| 115 | + |
| 116 | + It("should allow nil messagingBus and notificationsBus", func() { |
| 117 | + instance.Spec.MessagingBus = nil |
| 118 | + instance.Spec.NotificationsBus = nil |
| 119 | + |
| 120 | + errs := instance.ValidateMessagingBusConfig(basePath) |
| 121 | + Expect(errs).To(BeEmpty()) |
| 122 | + }) |
| 123 | + }) |
| 124 | +}) |
0 commit comments