Stop ignoring assignment in tests

Drop `assignment` from the test override's `disable_error_code`. Two
issues surfaced, both fixed at the source. In `tests/unit/utils.py`,
`FakeAPI._request` widened a fixed-length tuple with `+=`; build each
tuple shape directly and append to `self.calls`. In
`tests/unit/osc/v1/fakes.py`, `osc_lib`'s `FakeClientManager.auth_ref`
is inferred as `None`, so direct assignment is rejected; use `setattr`
with a TODO pointing at the upstream fix.

Change-Id: Ideda1f4c71e70b86e8f04d1d2d8af40d538429ce
Signed-off-by: Karan Anand <anandkarancompsci@gmail.com>

Author: anandkaranubc

ironicclient/tests/unit/osc/v1/fakes.py

@@ -353,7 +353,11 @@ class TestBaremetal(utils.TestCommand):
     def setUp(self) -> None:
         super(TestBaremetal, self).setUp()
 
-        self.app.client_manager.auth_ref = mock.Mock(auth_token="TOKEN")
+        # TODO(anandkaranubc): drop setattr once osc_lib annotates
+        # FakeClientManager.auth_ref as ``object | None`` (currently inferred
+        # as ``None``, so direct assignment trips ``[assignment]``).
+        setattr(self.app.client_manager, 'auth_ref',
+                mock.Mock(auth_token="TOKEN"))
         self.app.client_manager.baremetal = mock.Mock()
 
 

ironicclient/tests/unit/utils.py

@@ -68,10 +68,10 @@ def _request(
         # url should always just be a path here, e.g. /v1/nodes
         url = self.path_prefix + url
 
-        call = (method, url, headers or {}, body)
         if params:
-            call += (params,)
-        self.calls.append(call)
+            self.calls.append((method, url, headers or {}, body, params))
+        else:
+            self.calls.append((method, url, headers or {}, body))
         return self.responses[url][method]
 
     def raw_request(

pyproject.toml

@@ -201,7 +201,6 @@ disallow_untyped_defs = false
 disallow_subclassing_any = false
 disable_error_code = [
     "arg-type",
-    "assignment",
     "attr-defined",
     "call-arg",
     "dict-item",