typing: Remove unnecessary type: ignore statements

Many of these are trivially resolvable.

Change-Id: I0a8463a7ff9b0eff06426270987fdf862461d66a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Author: stephenfin

openstackclient/common/module.py

@@ -61,7 +61,7 @@ def take_action(self, parsed_args):
                 # TODO(bapalm): Fix this when cliff properly supports
                 # handling the detection rather than using the hard-code below.
                 if parsed_args.formatter == 'table':
-                    command_names = utils.format_list(command_names, "\n")  # type: ignore
+                    command_names = utils.format_list(command_names, "\n")  # type: ignore[assignment]
 
                 commands.append((group, command_names))
 

openstackclient/compute/v2/server.py

@@ -1909,6 +1909,7 @@ def _match_image(image_api, wanted_properties):
 
             networks = parsed_args.nics[0]
         else:
+            _networks = []
             for nic in parsed_args.nics:
                 if 'tag' in nic:
                     if not sdk_utils.supports_microversion(
@@ -1969,7 +1970,8 @@ def _match_image(image_api, wanted_properties):
                 if nic.get('tag'):  # tags are optional
                     network['tag'] = nic['tag']
 
-                networks.append(network)  # type: ignore[union-attr]
+                _networks.append(network)
+            networks = _networks
 
         if not parsed_args.nics and sdk_utils.supports_microversion(
             compute_client, '2.37'

openstackclient/image/v1/image.py

@@ -314,10 +314,10 @@ def take_action(self, parsed_args):
             else:
                 # Read file from stdin
                 if not sys.stdin.isatty():
-                    if os.name == "nt":
+                    if sys.platform == "win32":
                         import msvcrt
 
-                        msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)  # type: ignore
+                        msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
                     if hasattr(sys.stdin, 'buffer'):
                         kwargs['data'] = sys.stdin.buffer
                     else:
@@ -785,10 +785,10 @@ def take_action(self, parsed_args):
                     # Read file from stdin
                     if sys.stdin.isatty() is not True:
                         if parsed_args.stdin:
-                            if os.name == "nt":
+                            if sys.platform == "win32":
                                 import msvcrt
 
-                                msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)  # type: ignore
+                                msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
                             if hasattr(sys.stdin, 'buffer'):
                                 kwargs['data'] = sys.stdin.buffer
                             else:

openstackclient/image/v2/image.py

@@ -166,10 +166,10 @@ def get_data_from_stdin():
         image = sys.stdin
         if hasattr(sys.stdin, 'buffer'):
             image = sys.stdin.buffer
-        if os.name == "nt":
+        if sys.platform == "win32":
             import msvcrt
 
-            msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)  # type: ignore
+            msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
 
         return image
     else:

openstackclient/volume/v2/volume_type.py

@@ -14,6 +14,7 @@
 
 """Volume v2 Type action implementations"""
 
+from collections.abc import MutableMapping
 import functools
 import logging
 from typing import Any
@@ -439,7 +440,9 @@ def take_action(self, parsed_args):
                 is_public=parsed_args.is_public,
             )
 
-        formatters = {'Extra Specs': format_columns.DictColumn}
+        formatters: MutableMapping[str, Any] = {
+            'Extra Specs': format_columns.DictColumn
+        }
 
         if parsed_args.encryption_type:
             encryption = {}
@@ -466,7 +469,7 @@ def take_action(self, parsed_args):
             _EncryptionInfoColumn = functools.partial(
                 EncryptionInfoColumn, encryption_data=encryption
             )
-            formatters['id'] = _EncryptionInfoColumn  # type: ignore
+            formatters['id'] = _EncryptionInfoColumn
 
         return (
             column_headers,

openstackclient/volume/v3/volume_type.py

@@ -13,6 +13,7 @@
 
 """Volume v3 Type action implementations"""
 
+from collections.abc import MutableMapping
 import functools
 import logging
 from typing import Any
@@ -522,7 +523,9 @@ def take_action(self, parsed_args):
                 is_public=parsed_args.is_public,
             )
 
-        formatters = {'Extra Specs': format_columns.DictColumn}
+        formatters: MutableMapping[str, Any] = {
+            'Extra Specs': format_columns.DictColumn
+        }
 
         if parsed_args.encryption_type:
             encryption = {}
@@ -549,7 +552,7 @@ def take_action(self, parsed_args):
             _EncryptionInfoColumn = functools.partial(
                 EncryptionInfoColumn, encryption_data=encryption
             )
-            formatters['id'] = _EncryptionInfoColumn  # type: ignore
+            formatters['id'] = _EncryptionInfoColumn
 
         return (
             column_headers,