Skip to content

Commit 7197deb

Browse files
committed
volume: Migrate 'volume list' to SDK
We also drop an old column compat helper. Change-Id: Id9e2032be3378268b32402778b52c5a6d4ca834d Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
1 parent 72960a5 commit 7197deb

6 files changed

Lines changed: 262 additions & 678 deletions

File tree

openstackclient/tests/functional/volume/v2/test_volume.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -241,33 +241,3 @@ def test_volume_snapshot(self):
241241
# Deleting snapshot may take time. If volume snapshot still exists when
242242
# a parent volume delete is requested, the volume deletion will fail.
243243
self.wait_for_delete('volume snapshot', snapshot_name)
244-
245-
def test_volume_list_backward_compatibility(self):
246-
"""Test backward compatibility of list command"""
247-
name1 = uuid.uuid4().hex
248-
cmd_output = self.openstack(
249-
'volume create ' + '--size 1 ' + name1,
250-
parse_output=True,
251-
)
252-
self.addCleanup(self.openstack, 'volume delete ' + name1)
253-
self.assertEqual(
254-
1,
255-
cmd_output["size"],
256-
)
257-
self.wait_for_status("volume", name1, "available")
258-
259-
# Test list -c "Display Name"
260-
cmd_output = self.openstack(
261-
'volume list ' + '-c "Display Name"',
262-
parse_output=True,
263-
)
264-
for each_volume in cmd_output:
265-
self.assertIn('Display Name', each_volume)
266-
267-
# Test list -c "Name"
268-
cmd_output = self.openstack(
269-
'volume list ' + '-c "Name"',
270-
parse_output=True,
271-
)
272-
for each_volume in cmd_output:
273-
self.assertIn('Name', each_volume)

openstackclient/tests/functional/volume/v3/test_volume.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -242,33 +242,3 @@ def test_volume_snapshot(self):
242242
# Deleting snapshot may take time. If volume snapshot still exists when
243243
# a parent volume delete is requested, the volume deletion will fail.
244244
self.wait_for_delete('volume snapshot', snapshot_name)
245-
246-
def test_volume_list_backward_compatibility(self):
247-
"""Test backward compatibility of list command"""
248-
name1 = uuid.uuid4().hex
249-
cmd_output = self.openstack(
250-
'volume create --size 1 ' + name1,
251-
parse_output=True,
252-
)
253-
self.addCleanup(self.openstack, 'volume delete ' + name1)
254-
self.assertEqual(
255-
1,
256-
cmd_output["size"],
257-
)
258-
self.wait_for_status("volume", name1, "available")
259-
260-
# Test list -c "Display Name"
261-
cmd_output = self.openstack(
262-
'volume list -c "Display Name"',
263-
parse_output=True,
264-
)
265-
for each_volume in cmd_output:
266-
self.assertIn('Display Name', each_volume)
267-
268-
# Test list -c "Name"
269-
cmd_output = self.openstack(
270-
'volume list -c "Name"',
271-
parse_output=True,
272-
)
273-
for each_volume in cmd_output:
274-
self.assertIn('Name', each_volume)

0 commit comments

Comments
 (0)