Create shared extension method IsExtensibleJsonObject

Author: sharwell

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentValueFromSummaryAnalyzer.cs

@@ -51,7 +51,7 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context)
                 return;
 
             INamedTypeSymbol declaringType = propertySymbol.ContainingType;
-            if (!IsExtensibleJsonObject(declaringType))
+            if (!declaringType.IsExtensibleJsonObject())
                 return;
 
             DocumentationCommentTriviaSyntax documentationTriviaSyntax = GetDocumentationCommentTriviaSyntax(syntax);
@@ -65,19 +65,6 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context)
             context.ReportDiagnostic(Diagnostic.Create(Descriptor, syntax.Identifier.GetLocation()));
         }
 
-        private bool IsExtensibleJsonObject(INamedTypeSymbol symbol)
-        {
-            while (symbol != null && symbol.SpecialType != SpecialType.System_Object)
-            {
-                if (string.Equals("global::OpenStack.ObjectModel.ExtensibleJsonObject", symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat), StringComparison.Ordinal))
-                    return true;
-
-                symbol = symbol.BaseType;
-            }
-
-            return false;
-        }
-
         internal static DocumentationCommentTriviaSyntax GetDocumentationCommentTriviaSyntax(SyntaxNode node)
         {
             if (node == null)

OpenStackNetAnalyzers/OpenStackNetAnalyzers/ImplementBuilderPatternAnalyzer.cs

@@ -42,7 +42,7 @@ private void HandleNamedType(SymbolAnalysisContext context)
             if (symbol.TypeKind != TypeKind.Class)
                 return;
 
-            if (!IsExtensibleJsonObject(symbol))
+            if (!symbol.IsExtensibleJsonObject())
                 return;
 
             foreach (var propertySymbol in symbol.GetMembers().OfType<IPropertySymbol>())
@@ -82,18 +82,5 @@ private void HandleNamedType(SymbolAnalysisContext context)
                 }
             }
         }
-
-        private bool IsExtensibleJsonObject(INamedTypeSymbol symbol)
-        {
-            while (symbol != null && symbol.SpecialType != SpecialType.System_Object)
-            {
-                if (string.Equals("global::OpenStack.ObjectModel.ExtensibleJsonObject", symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat), StringComparison.Ordinal))
-                    return true;
-
-                symbol = symbol.BaseType;
-            }
-
-            return false;
-        }
     }
 }

OpenStackNetAnalyzers/OpenStackNetAnalyzers/OpenStackNetAnalyzers.csproj

@@ -47,6 +47,7 @@
     <Compile Include="PlaceholderDocumentationAnalyzer.cs" />
     <Compile Include="PlaceholderDocumentationCodeFix.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
+    <Compile Include="SdkTypeSymbolExtensions.cs" />
     <Compile Include="SpacingExtensions.cs" />
     <Compile Include="TypeSymbolExtensions.cs" />
     <Compile Include="XmlSyntaxFactory.cs" />

OpenStackNetAnalyzers/OpenStackNetAnalyzers/SdkTypeSymbolExtensions.cs

@@ -0,0 +1,23 @@
+namespace OpenStackNetAnalyzers
+{
+    using System;
+    using Microsoft.CodeAnalysis;
+
+    internal static class SdkTypeSymbolExtensions
+    {
+        private const string FullyQualifiedExtensibleJsonObject = "global::OpenStack.ObjectModel.ExtensibleJsonObject";
+
+        public static bool IsExtensibleJsonObject(this INamedTypeSymbol symbol)
+        {
+            while (symbol != null && symbol.SpecialType != SpecialType.System_Object)
+            {
+                if (string.Equals(FullyQualifiedExtensibleJsonObject, symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat), StringComparison.Ordinal))
+                    return true;
+
+                symbol = symbol.BaseType;
+            }
+
+            return false;
+        }
+    }
+}