Fix XmlSyntaxFactory's handling of generic type and member names

Author: sharwell

OpenStackNetAnalyzers/OpenStackNetAnalyzers/DocumentDelegatingApiCallCodeFix.cs

@@ -120,14 +120,14 @@ private async Task<ConstructorDeclarationSyntax> DocumentConstructorAsync(CodeFi
                     XmlSyntaxFactory.Text(" class"),
                     XmlSyntaxFactory.NewLine(),
                     XmlSyntaxFactory.Text("with the behavior provided by another "),
-                    XmlSyntaxFactory.SeeElement(SyntaxFactory.TypeCref(SyntaxFactory.ParseTypeName("global::OpenStack.Net.IHttpApiCall{T}"))),
+                    XmlSyntaxFactory.SeeElement(SyntaxFactory.TypeCref(SyntaxFactory.ParseTypeName("global::OpenStack.Net.IHttpApiCall<T>"))),
                     XmlSyntaxFactory.Text(" instance.")),
                 XmlSyntaxFactory.NewLine(),
                 XmlSyntaxFactory.ParamElement(
                     parameterName,
                     XmlSyntaxFactory.List(
                         XmlSyntaxFactory.Text("The "),
-                        XmlSyntaxFactory.SeeElement(SyntaxFactory.TypeCref(SyntaxFactory.ParseTypeName("global::OpenStack.Net.IHttpApiCall{T}"))),
+                        XmlSyntaxFactory.SeeElement(SyntaxFactory.TypeCref(SyntaxFactory.ParseTypeName("global::OpenStack.Net.IHttpApiCall<T>"))),
                         XmlSyntaxFactory.Text(" providing the behavior for the API call."))),
                 XmlSyntaxFactory.NewLine(),
                 XmlSyntaxFactory.ExceptionElement(

OpenStackNetAnalyzers/OpenStackNetAnalyzers/XmlSyntaxFactory.cs

@@ -103,6 +103,7 @@ public static XmlCrefAttributeSyntax CrefAttribute(CrefSyntax cref)
 
         public static XmlCrefAttributeSyntax CrefAttribute(CrefSyntax cref, SyntaxKind quoteKind)
         {
+            cref = cref.ReplaceTokens(cref.DescendantTokens(), ReplaceBracketTokens);
             return SyntaxFactory.XmlCrefAttribute(
                 SyntaxFactory.XmlName("cref"),
                 SyntaxFactory.Token(quoteKind),
@@ -275,5 +276,16 @@ public static XmlEmptyElementSyntax PreliminaryElement()
         {
             return EmptyElement("preliminary");
         }
+
+        private static SyntaxToken ReplaceBracketTokens(SyntaxToken originalToken, SyntaxToken rewrittenToken)
+        {
+            if (rewrittenToken.IsKind(SyntaxKind.LessThanToken) && string.Equals("<", rewrittenToken.Text, StringComparison.Ordinal))
+                return SyntaxFactory.Token(rewrittenToken.LeadingTrivia, SyntaxKind.LessThanToken, "{", rewrittenToken.ValueText, rewrittenToken.TrailingTrivia);
+
+            if (rewrittenToken.IsKind(SyntaxKind.GreaterThanToken) && string.Equals(">", rewrittenToken.Text, StringComparison.Ordinal))
+                return SyntaxFactory.Token(rewrittenToken.LeadingTrivia, SyntaxKind.GreaterThanToken, "}", rewrittenToken.ValueText, rewrittenToken.TrailingTrivia);
+
+            return rewrittenToken;
+        }
     }
 }