Fix handling of parameter symbols when looking for non-nullable JSON properties

Author: sharwell

OpenStackNetAnalyzers/OpenStackNetAnalyzers/NonNullableJsonPropertyAnalyzer.cs

@@ -32,7 +32,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
         public override void Initialize(AnalysisContext context)
         {
             context.RegisterSymbolAction(HandleField, SymbolKind.Field);
-            context.RegisterSymbolAction(HandleParameter, SymbolKind.Parameter);
+            context.RegisterSymbolAction(HandleMethod, SymbolKind.Method);
             context.RegisterSymbolAction(HandleProperty, SymbolKind.Property);
         }
 
@@ -42,9 +42,18 @@ private void HandleField(SymbolAnalysisContext context)
             AnalyzeSymbol(context, symbol, symbol.Type);
         }
 
-        private void HandleParameter(SymbolAnalysisContext context)
+        private void HandleMethod(SymbolAnalysisContext context)
+        {
+            IMethodSymbol symbol = (IMethodSymbol)context.Symbol;
+            if (symbol.MethodKind != MethodKind.Constructor)
+                return;
+
+            foreach (var parameter in symbol.Parameters)
+                HandleParameter(context, parameter);
+        }
+
+        private void HandleParameter(SymbolAnalysisContext context, IParameterSymbol symbol)
         {
-            IParameterSymbol symbol = (IParameterSymbol)context.Symbol;
             AnalyzeSymbol(context, symbol, symbol.Type);
         }