Reduce severity of non-critical diagnostics

Author: sharwell

OpenStackNetAnalyzers/OpenStackNetAnalyzers/JsonObjectOptInAnalyzer.cs

@@ -17,7 +17,7 @@ public class JsonObjectOptInAnalyzer : DiagnosticAnalyzer
         internal const string Description = "JSON objects should specify MemberSerialization.OptIn";
 
         private static DiagnosticDescriptor Descriptor =
-            new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);
+            new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
         private static readonly ImmutableArray<DiagnosticDescriptor> _supportedDiagnostics =
             ImmutableArray.Create(Descriptor);

OpenStackNetAnalyzers/OpenStackNetAnalyzers/JsonPropertyDefaultValueHandlingAnalyzer.cs

@@ -17,7 +17,7 @@ public class JsonPropertyDefaultValueHandlingAnalyzer : DiagnosticAnalyzer
         internal const string Description = "JSON properties should specify DefaultValueHandling.Ignore";
 
         private static DiagnosticDescriptor Descriptor =
-            new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);
+            new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
         private static readonly ImmutableArray<DiagnosticDescriptor> _supportedDiagnostics =
             ImmutableArray.Create(Descriptor);

OpenStackNetAnalyzers/OpenStackNetAnalyzers/NonNullableJsonPropertyAnalyzer.cs

@@ -16,7 +16,7 @@ public class NonNullableJsonPropertyAnalyzer : DiagnosticAnalyzer
         internal const string Description = "JSON properties should use nullable types";
 
         private static DiagnosticDescriptor Descriptor =
-            new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);
+            new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
         private static readonly ImmutableArray<DiagnosticDescriptor> _supportedDiagnostics =
             ImmutableArray.Create(Descriptor);