Validate domain output

Author: max-lt

src/config/index.ts

@@ -1,7 +1,12 @@
 import { z } from "zod";
 
 // Environment schema
-const EnvironmentSchema = z.enum(["development", "staging", "production", "test"]);
+const EnvironmentSchema = z.enum([
+  "development",
+  "staging",
+  "production",
+  "test",
+]);
 
 // Configuration schema
 const ConfigSchema = z.object({
@@ -23,11 +28,15 @@ const ConfigSchema = z.object({
   // JWT
   jwt: z.object({
     access: z.object({
-      secret: z.string().min(32, "JWT_ACCESS_SECRET must be at least 32 characters"),
+      secret: z
+        .string()
+        .min(32, "JWT_ACCESS_SECRET must be at least 32 characters"),
       expiresIn: z.string().default("15m"),
     }),
     refresh: z.object({
-      secret: z.string().min(32, "JWT_REFRESH_SECRET must be at least 32 characters"),
+      secret: z
+        .string()
+        .min(32, "JWT_REFRESH_SECRET must be at least 32 characters"),
       expiresIn: z.string().default("18h"),
     }),
   }),
@@ -90,7 +99,9 @@ function loadConfig(): Config {
 
     // Warn about missing GitHub OAuth
     if (!config.github.clientId || !config.github.clientSecret) {
-      console.warn("⚠️  GitHub OAuth not configured (GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET missing)");
+      console.warn(
+        "⚠️  GitHub OAuth not configured (GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET missing)"
+      );
     }
 
     return config;

src/routes/auth.ts

@@ -3,7 +3,7 @@ import { setCookie } from "hono/cookie";
 import { verify } from "hono/jwt";
 import { authService } from "../services/auth";
 import { github as githubConfig, jwt as jwtConfig } from "../config";
-import { LoginResponseSchema, type JWTPayload } from "../types";
+import { LoginResponseSchema } from "../types";
 import { jsonResponse } from "../utils/validate";
 
 const auth = new Hono();
@@ -86,7 +86,7 @@ auth.get("/callback/github", async (c) => {
     // Create JWT tokens
     const tokens = await authService.createTokens(user);
 
-    // Set access_token cookie (only access token, not refresh)
+    // Set access_token cookie
     setCookie(c, "access_token", tokens.accessToken, {
       httpOnly: true,
       secure: true,
@@ -127,6 +127,13 @@ auth.post("/refresh", async (c) => {
     // Generate new tokens
     const tokens = await authService.refreshTokens(payload.sub);
 
+    // Set access_token cookie
+    setCookie(c, "access_token", tokens.accessToken, {
+      httpOnly: true,
+      secure: true,
+      sameSite: "Strict",
+    });
+
     return jsonResponse(c, LoginResponseSchema, tokens);
   } catch (error) {
     console.error("Refresh token verification failed:", error);

src/routes/crons.ts

@@ -1,6 +1,8 @@
 import { Hono } from 'hono';
 import { cronsService } from '../services/crons';
 import { workersService } from '../services/workers';
+import { CronCreateInputSchema, CronUpdateInputSchema, CronSchema } from '../types';
+import { jsonResponse } from '../utils/validate';
 
 const crons = new Hono();
 
@@ -10,16 +12,11 @@ crons.put('/:id', async (c) => {
     const id = c.req.param('id');
     const body = await c.req.json();
 
-    if (!body.value) {
-        return c.json({ error: 'Missing required field: value' }, 400);
-    }
-
     try {
-        const cron = await cronsService.update(userId, id, {
-            value: body.value,
-        });
+        const payload = CronUpdateInputSchema.parse(body);
+        const cron = await cronsService.update(userId, id, payload);
 
-        return c.json(cron);
+        return jsonResponse(c, CronSchema, cron);
     } catch (error) {
         console.error('Failed to update cron:', error);
         return c.json({
@@ -61,16 +58,10 @@ crons.post('/', async (c) => {
     const userId = c.get('userId');
     const body = await c.req.json();
 
-    if (!body.workerId || !body.value) {
-        return c.json({ error: 'Missing required fields: workerId, value' }, 400);
-    }
-
     try {
-        const cron = await cronsService.create(userId, {
-            workerId: body.workerId,
-            value: body.value
-        });
-        return c.json(cron, 201);
+        const payload = CronCreateInputSchema.parse(body);
+        const cron = await cronsService.create(userId, payload);
+        return jsonResponse(c, CronSchema, cron, 201);
     } catch (error) {
         console.error('Failed to create cron:', error);
         return c.json({

src/routes/domains.ts

@@ -1,5 +1,7 @@
 import { Hono } from 'hono';
 import { domainsService } from '../services/domains';
+import { DomainFullSchema, DomainCreateInputSchema } from '../types';
+import { jsonResponse, jsonArrayResponse } from '../utils/validate';
 
 const domains = new Hono();
 
@@ -8,7 +10,7 @@ domains.get('/', async (c) => {
     const userId = c.get('userId');
     try {
         const domains = await domainsService.findAll(userId);
-        return c.json(domains);
+        return jsonArrayResponse(c, DomainFullSchema, domains);
     } catch (error) {
         console.error('Failed to fetch domains:', error);
         return c.json({ error: 'Failed to fetch domains' }, 500);
@@ -20,16 +22,10 @@ domains.post('/', async (c) => {
     const userId = c.get('userId');
     const body = await c.req.json();
 
-    if (!body.name || !body.workerId) {
-        return c.json({ error: 'Missing required fields: name, workerId' }, 400);
-    }
-
     try {
-        const domain = await domainsService.create(userId, {
-            name: body.name,
-            workerId: body.workerId
-        });
-        return c.json(domain, 201);
+        const payload = DomainCreateInputSchema.parse(body);
+        const domain = await domainsService.create(userId, payload);
+        return jsonResponse(c, DomainFullSchema, domain, 201);
     } catch (error) {
         console.error('Failed to create domain:', error);
         return c.json({