Add tests and wrap migrations in transactions

max-lt · max-lt · commit f0c16d04f3f2 · 2026-01-19T23:02:51.000+01:00
- Add unit tests for config module (17 tests)
- Add unit tests for workers commands with mock backend (15 tests)
- Fix password masking for URLs with @ in password
- Wrap all migrations in BEGIN/COMMIT for atomicity
- Add tempfile dev dependency for tests
- Remove unused get_default_alias method
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -22,3 +22,7 @@ uuid = { version = "1", features = ["serde"] }
 reqwest = { version = "0.12", features = ["json"] }
 sha2 = "0.10"
 hex = "0.4"
+
+[dev-dependencies]
+tempfile = "3"
+uuid = { version = "1", features = ["v4"] }
diff --git a/migrations/00_init.sql b/migrations/00_init.sql
@@ -2,6 +2,8 @@
 -- OpenWorkers Database Schema - Initial Schema
 --
 
+BEGIN;
+
 SET client_encoding = 'UTF8';
 
 -- ============================================================================
@@ -153,3 +155,5 @@ CREATE TRIGGER cron_update
     AFTER INSERT OR DELETE OR UPDATE ON crons
     FOR EACH ROW
     EXECUTE FUNCTION cron_update();
+
+COMMIT;
diff --git a/migrations/01_add_scheduled_events_cascade.sql b/migrations/01_add_scheduled_events_cascade.sql
@@ -6,6 +6,8 @@
 -- when their parent worker is deleted.
 --
 
+BEGIN;
+
 -- Drop the existing constraint
 ALTER TABLE scheduled_events
     DROP CONSTRAINT IF EXISTS scheduled_events_worker_id_fkey;
@@ -17,3 +19,5 @@ ALTER TABLE scheduled_events
     REFERENCES workers(id)
     ON UPDATE CASCADE
     ON DELETE CASCADE;
+
+COMMIT;
diff --git a/migrations/02_auto_timestamps_and_uuids.sql b/migrations/02_auto_timestamps_and_uuids.sql
@@ -7,6 +7,8 @@
 -- 3. Auto-updated updated_at timestamps via trigger function
 --
 
+BEGIN;
+
 -- ============================================================================
 -- FUNCTION: Auto update updated_at
 -- ============================================================================
@@ -105,3 +107,5 @@ CREATE TRIGGER update_crons_updated_at_trigger
     BEFORE UPDATE ON crons
     FOR EACH ROW
     EXECUTE FUNCTION auto_updated_at();
+
+COMMIT;
diff --git a/migrations/03_databases.sql b/migrations/03_databases.sql
@@ -3,6 +3,8 @@
 -- Links openworkers users to postgate databases
 --
 
+BEGIN;
+
 -- Databases (references to postgate)
 CREATE TABLE databases (
     id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
@@ -23,3 +25,5 @@ CREATE TRIGGER update_databases_updated_at_trigger
     BEFORE UPDATE ON databases
     FOR EACH ROW
     EXECUTE FUNCTION auto_updated_at();
+
+COMMIT;
diff --git a/migrations/04_add_databases_resource_limit.sql b/migrations/04_add_databases_resource_limit.sql
@@ -2,6 +2,8 @@
 -- OpenWorkers Database Schema - Add databases to resource_limits
 --
 
+BEGIN;
+
 -- Update default for resource_limits column
 ALTER TABLE users
 ALTER COLUMN resource_limits SET DEFAULT '{"workers": 5, "environments": 5, "databases": 3}'::jsonb;
@@ -10,3 +12,5 @@ ALTER COLUMN resource_limits SET DEFAULT '{"workers": 5, "environments": 5, "dat
 UPDATE users
 SET resource_limits = resource_limits || '{"databases": 3}'::jsonb
 WHERE NOT resource_limits ? 'databases';
+
+COMMIT;
diff --git a/migrations/05_add_token_id.sql b/migrations/05_add_token_id.sql
@@ -3,7 +3,11 @@
 -- This stores the postgate token ID (not the secret) for reference
 --
 
+BEGIN;
+
 ALTER TABLE databases ADD COLUMN token_id uuid;
 
 -- Create index for token lookup
 CREATE INDEX idx_databases_token_id ON databases(token_id);
+
+COMMIT;
diff --git a/migrations/06_endpoints_and_projects.sql b/migrations/06_endpoints_and_projects.sql
@@ -6,6 +6,8 @@
 -- and points to either a worker (direct dispatch) or a project (route matching).
 --
 
+BEGIN;
+
 -- ============================================================================
 -- ENUMS
 -- ============================================================================
@@ -85,3 +87,5 @@ CREATE INDEX idx_endpoints_type ON endpoints(type);
 CREATE INDEX idx_projects_user_id ON projects(user_id);
 CREATE INDEX idx_project_routes_project_id ON project_routes(project_id);
 CREATE INDEX idx_project_routes_priority ON project_routes(project_id, priority DESC);
+
+COMMIT;
diff --git a/migrations/07_binding_types.sql b/migrations/07_binding_types.sql
@@ -8,6 +8,8 @@
 -- of the corresponding config table. No FK constraint, validated by CHECK.
 --
 
+BEGIN;
+
 -- ============================================================================
 -- ENUMS
 -- ============================================================================
@@ -122,3 +124,5 @@ COMMENT ON COLUMN storage_configs.public_url IS 'Optional CDN URL for public acc
 
 COMMENT ON COLUMN environment_values.type IS 'Binding type: var, secret, assets, storage, kv';
 COMMENT ON COLUMN environment_values.value IS 'For var/secret: the value. For bindings: UUID of config table';
+
+COMMIT;
diff --git a/migrations/08_resource_limits_columns.sql b/migrations/08_resource_limits_columns.sql
@@ -5,6 +5,8 @@
 -- and adds new limits for kv and storage config bindings.
 --
 
+BEGIN;
+
 -- ============================================================================
 -- ADD NEW COLUMNS
 -- ============================================================================
@@ -42,3 +44,5 @@ COMMENT ON COLUMN users.limit_databases IS 'Max number of database bindings this
 COMMENT ON COLUMN users.limit_kv IS 'Max number of KV namespaces this user can create';
 COMMENT ON COLUMN users.limit_storage IS 'Max number of storage configs this user can create (used for both assets and storage bindings)';
 COMMENT ON COLUMN users.second_precision IS 'Whether user can use second-precision cron expressions';
+
+COMMIT;
diff --git a/migrations/09_add_database_binding_type.sql b/migrations/09_add_database_binding_type.sql
@@ -1,8 +1,10 @@
 --
 -- OpenWorkers Database Schema - Add 'database' binding type
 --
--- Must be separate from 09b because PostgreSQL cannot use
+-- Must be separate from 10_database_configs because PostgreSQL cannot use
 -- a newly added enum value in the same transaction.
 --
+-- NOTE: No BEGIN/COMMIT - ALTER TYPE ADD VALUE cannot run inside a transaction block.
+--
 
 ALTER TYPE enum_binding_type ADD VALUE 'database';
diff --git a/migrations/10_database_configs.sql b/migrations/10_database_configs.sql
@@ -6,6 +6,8 @@
 --   - postgres: direct connection (can be Supabase, PlanetScale, Neon, etc.)
 --
 
+BEGIN;
+
 -- ============================================================================
 -- TABLE: database_configs
 -- ============================================================================
@@ -350,3 +352,5 @@ COMMENT ON COLUMN database_configs.max_rows IS 'Maximum rows returned per query'
 COMMENT ON COLUMN database_configs.timeout_seconds IS 'Query timeout in seconds';
 
 COMMENT ON COLUMN environment_values.value IS 'For var/secret: the value. For bindings: UUID of config table (storage_configs, kv_configs, database_configs)';
+
+COMMIT;
diff --git a/migrations/11_provider_enums.sql b/migrations/11_provider_enums.sql
@@ -4,6 +4,8 @@
 -- Converts database_configs.provider from VARCHAR to ENUM for type safety
 --
 
+BEGIN;
+
 -- ============================================================================
 -- ENUM: Database provider
 -- ============================================================================
@@ -39,3 +41,5 @@ ALTER TABLE database_configs DROP COLUMN provider_old;
 -- ============================================================================
 
 COMMENT ON COLUMN database_configs.provider IS 'Database provider: platform (shared multi-tenant) or postgres (external connection)';
+
+COMMIT;
diff --git a/migrations/12_add_worker_binding_type.sql b/migrations/12_add_worker_binding_type.sql
@@ -1,8 +1,10 @@
 --
 -- OpenWorkers Database Schema - Add 'worker' binding type
 --
--- Must be separate from 11b because PostgreSQL cannot use
+-- Must be separate from 13_worker_bindings because PostgreSQL cannot use
 -- a newly added enum value in the same transaction.
 --
+-- NOTE: No BEGIN/COMMIT - ALTER TYPE ADD VALUE cannot run inside a transaction block.
+--
 
 ALTER TYPE enum_binding_type ADD VALUE 'worker';
diff --git a/migrations/13_worker_bindings.sql b/migrations/13_worker_bindings.sql
@@ -5,6 +5,8 @@
 -- The binding value references workers.id directly (no config table needed)
 --
 
+BEGIN;
+
 -- ============================================================================
 -- UPDATE CONSTRAINT: Add 'worker' to environment_values check
 -- ============================================================================
@@ -24,3 +26,5 @@ ADD CONSTRAINT check_binding_value CHECK (
 -- ============================================================================
 
 COMMENT ON TYPE enum_binding_type IS 'Binding types: var, secret, assets, storage, kv, database, worker';
+
+COMMIT;
diff --git a/migrations/14_kv_jsonb_value.sql b/migrations/14_kv_jsonb_value.sql
@@ -1,10 +1,14 @@
 -- Migration: Convert KV values from TEXT to JSONB
 -- This enables storing native JSON types (strings, numbers, booleans, objects, arrays)
 
+BEGIN;
+
 -- Convert existing text values to JSONB strings
 -- to_jsonb(text) wraps the text as a JSON string: "hello" -> "\"hello\""
 ALTER TABLE kv_data
 ALTER COLUMN value TYPE jsonb USING to_jsonb(value);
 
 -- Add a comment documenting the change
 COMMENT ON COLUMN kv_data.value IS 'JSON value - supports strings, numbers, booleans, objects, arrays';
+
+COMMIT;
diff --git a/migrations/15_postgate_compat.sql b/migrations/15_postgate_compat.sql
@@ -7,6 +7,8 @@
 --   3. Creates views so Postgate can work with OpenWorkers schema
 --
 
+BEGIN;
+
 -- ============================================================================
 -- TABLE: database_tokens
 -- ============================================================================
@@ -232,3 +234,5 @@ COMMENT ON TABLE database_tokens IS 'Authentication tokens for database access v
 COMMENT ON VIEW postgate_databases IS 'Compatibility view for Postgate - maps to database_configs';
 COMMENT ON VIEW postgate_tokens IS 'Compatibility view for Postgate - maps to database_tokens';
 COMMENT ON FUNCTION create_tenant_database IS 'Creates a tenant database (used by Postgate CLI)';
+
+COMMIT;
diff --git a/migrations/16_password_auth.sql b/migrations/16_password_auth.sql
@@ -5,6 +5,8 @@
 -- Flow: Register email -> Click link -> Set password (validates email implicitly)
 --
 
+BEGIN;
+
 -- ============================================================================
 -- USER TABLE CHANGES
 -- ============================================================================
@@ -60,3 +62,5 @@ CREATE TRIGGER trg_cleanup_expired_tokens
 COMMENT ON COLUMN users.password_hash IS 'PBKDF2 hash for email-based authentication. NULL for OAuth-only users or pending registration.';
 COMMENT ON TABLE auth_tokens IS 'Temporary tokens for set-password (registration) and password reset flows.';
 COMMENT ON COLUMN auth_tokens.type IS 'Token type: set_password (24h expiry, registration) or password_reset (1h expiry).';
+
+COMMIT;
diff --git a/migrations/17_api_keys.sql b/migrations/17_api_keys.sql
@@ -5,6 +5,8 @@
 -- Tokens are hashed (SHA-256) for security - only the prefix is stored in plain text.
 --
 
+BEGIN;
+
 -- ============================================================================
 -- API KEYS TABLE
 -- ============================================================================
@@ -35,3 +37,5 @@ COMMENT ON TABLE api_keys IS 'API keys for programmatic access. Tokens are SHA-2
 COMMENT ON COLUMN api_keys.token_prefix IS 'First 12 chars of token (e.g., "ow_a1b2c3d4") for identification in UI.';
 COMMENT ON COLUMN api_keys.token_hash IS 'SHA-256 hash of the full token.';
 COMMENT ON COLUMN api_keys.expires_at IS 'Optional expiration. NULL means never expires.';
+
+COMMIT;
diff --git a/src/backend/mock.rs b/src/backend/mock.rs
diff --git a/src/backend/mod.rs b/src/backend/mod.rs
diff --git a/src/commands/alias.rs b/src/commands/alias.rs
diff --git a/src/commands/workers.rs b/src/commands/workers.rs
diff --git a/src/config.rs b/src/config.rs
