Merge upstream denoland/rusty_v8 into openworkers/rusty-v8

Brings in simdutf support, crdtp/deno_inspector, PlatformImpl task ownership.

Resolved conflicts:
- Cargo.toml: kept openworkers-v8 name/description, took upstream version 146.8.0
- ci.yml: kept our features string system (none/ptrcomp/sandbox), removed upstream
  simdutf-only builds, simdutf now always enabled in all builds
- Cargo.lock: regenerated from scratch

Author: max-lt

.github/workflows/ci.yml

@@ -115,7 +115,6 @@ jobs:
             variant: release
             features: none
 
-
     env:
       V8_FROM_SOURCE: true
       CARGO_VARIANT_FLAG: ${{ matrix.config.variant == 'release' && '--release' || '' }}
@@ -154,13 +153,13 @@ jobs:
         shell: bash
         run: |
           if [ "${{ matrix.config.features }}" = "sandbox" ]; then
-            echo "CARGO_FEATURE_FLAGS=--features v8_enable_sandbox" >> $GITHUB_ENV
+            echo "CARGO_FEATURE_FLAGS=--features v8_enable_sandbox --features simdutf" >> $GITHUB_ENV
             echo "FEATURES_SUFFIX=_sandbox" >> $GITHUB_ENV
           elif [ "${{ matrix.config.features }}" = "ptrcomp" ]; then
-            echo "CARGO_FEATURE_FLAGS=--features v8_enable_pointer_compression" >> $GITHUB_ENV
+            echo "CARGO_FEATURE_FLAGS=--features v8_enable_pointer_compression --features simdutf" >> $GITHUB_ENV
             echo "FEATURES_SUFFIX=_ptrcomp" >> $GITHUB_ENV
           else
-            echo "CARGO_FEATURE_FLAGS=" >> $GITHUB_ENV
+            echo "CARGO_FEATURE_FLAGS=--features simdutf" >> $GITHUB_ENV
             echo "FEATURES_SUFFIX=" >> $GITHUB_ENV
           fi
 

BUILD.gn

@@ -1,15 +1,27 @@
 # Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
 import("//build/config/host_byteorder.gni")
 
+declare_args() {
+  rusty_v8_enable_simdutf = false
+}
+
 static_library("rusty_v8") {
   complete_static_lib = true
-  sources = [ "src/binding.cc" ]
+  sources = [
+    "src/binding.cc",
+    "src/crdtp_binding.cc",
+  ]
   deps = [
     "//build/config:shared_library_deps",
     "//v8:v8",
     "//v8:v8_libbase",
     "//v8:v8_libplatform",
+    "//v8/third_party/inspector_protocol:crdtp",
+    "//src/deno_inspector:deno_inspector_protocol",
   ]
+  if (rusty_v8_enable_simdutf) {
+    deps += [ "//third_party/simdutf:simdutf" ]
+  }
   configs -= [
     "//build/config/compiler:default_init_stack_vars",
     "//build/config/compiler:thin_archive",
@@ -33,12 +45,22 @@ config("rusty_v8_config") {
   # We need these directories in the search path to be able to include some
   # internal V8 headers.
   include_dirs = [
+    ".",
     "v8",
+    ".",
+    "$target_gen_dir",
     "$target_gen_dir/v8",
+    "$target_gen_dir/src/inspector",
+    "$target_gen_dir/src/deno_inspector",
   ]
 
+  defines = []
   if (is_debug) {
-    defines = [ "DEBUG" ]
+    defines += [ "DEBUG" ]
+  }
+
+  if (rusty_v8_enable_simdutf) {
+    defines += [ "RUSTY_V8_ENABLE_SIMDUTF" ]
   }
 
   if (is_clang) {

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "openworkers-v8"
-version = "146.5.2"
+version = "146.8.0"
 description = "Rust bindings to V8 (fork with Locker/UnenteredIsolate support for isolate pooling)"
 readme = "README.md"
 authors = ["the Deno authors", "OpenWorkers Authors <contact@openworkers.dev>"]
@@ -105,6 +105,7 @@ opt-level = 1
 [features]
 default = ["use_custom_libcxx"]
 use_custom_libcxx = []
+simdutf = []
 v8_enable_pointer_compression = []
 v8_enable_sandbox = ["v8_enable_pointer_compression"]
 v8_enable_v8_checks = []

Cargo.toml

@@ -312,6 +312,11 @@ fn build_v8(is_asan: bool) {
     env::var("CARGO_FEATURE_V8_ENABLE_V8_CHECKS").is_ok()
   ));
 
+  gn_args.push(format!(
+    "rusty_v8_enable_simdutf={}",
+    env::var("CARGO_FEATURE_SIMDUTF").is_ok()
+  ));
+
   // Fix GN's host_cpu detection when using x86_64 bins on Apple Silicon
   if cfg!(target_os = "macos") && cfg!(target_arch = "aarch64") {
     gn_args.push("host_cpu=\"arm64\"".to_string());
@@ -539,6 +544,9 @@ fn prebuilt_features_suffix() -> String {
   if env::var("CARGO_FEATURE_V8_ENABLE_SANDBOX").is_ok() {
     features.push_str("_sandbox");
   }
+  if env::var("CARGO_FEATURE_SIMDUTF").is_ok() {
+    features.push_str("_simdutf");
+  }
   features
 }