Adding exception handling.

client_from_file will now catch errors if the config file is
missing a required parameter for the ox3apiclient.Client instance.

Author: tnydwrds

ox3apiclient/__init__.py

@@ -237,9 +237,13 @@ def client_from_file(file_path='.ox3rc', env=None):
 
     client_params = {}
 
-    # TODO: Catch NoOptionErrors.
-    for key in required_params:
-        client_params[key] = cp.get(env, key)
+    # Load required parameters.
+    try:
+        for key in required_params:
+            client_params[key] = cp.get(env, key)
+    except ConfigParser.NoOptionError:
+        err_msg = "Missing required option: '%s'" % key
+        raise Exception(err_msg)
 
     # TODO: Add support for optional parameters.
 

tests/clientfromfile.py

@@ -51,3 +51,11 @@ def test_loads_alternate_env(self):
         test_values.sort()
         loaded_values.sort()
         self.assertEqual(loaded_values, test_values)
+
+    def test_missing_required_option_raises_error(self):
+        file_path = os.path.join(os.path.dirname(__file__), 'ox3rctest')
+        self.assertRaises(
+            Exception,
+            ox3apiclient.client_from_file,
+            file_path,
+            'missing-required-option')

tests/ox3rctest

@@ -2,6 +2,7 @@
 envs=
     prod
     dev
+    missing-required-option
 
 [prod]
 email: email
@@ -18,3 +19,10 @@ domain: domain_dev
 realm: realm_dev
 consumer_key: consumer_key_dev
 consumer_secret: consumer_secret_dev
+
+[missing-required-option]
+email: email
+password: password
+domain: domain
+realm: realm
+consumer_key: consumer_key