Merge pull request #142 from openxc/sonar-qube-flags

Resolve SonarQube Red Flag Issues (1/2)

Author: PPRAKA30

docs/_static/rtd.css

@@ -382,12 +382,6 @@ div.sphinxsidebar p a:hover {
     border: 1px solid #888;
 }
 
-/* Tweak any link appearing in a heading */
-div.sphinxsidebar h3 a {
-}
-
-
-
 
 /* OTHER STUFF ------------------------------------------------------------ */
 

openxc/formats/binary.py

@@ -68,7 +68,6 @@ def deserialize(cls, data):
         except UnicodeDecodeError as e:
             LOG.warn("Unable to parse protobuf: %s", e)
         else:
-            #return type(cls._protobuf_to_dict(message)['payload'])
             return cls._protobuf_to_dict(message)
 
     @classmethod

openxc/tools/diagnostics.py

@@ -49,8 +49,8 @@ def diagnostic_request(arguments, controller):
                     # Stripping all of the unnesseary data we get after sending a diag request in python
                     # Just like in enabler, it's a diag response if it contains the keys "mode", "bus", 
                     # "id", and "success". 
-                    diagMsgReqKeys = ['mode', 'bus', 'id', 'success']
-                    indices = [i for i, s in enumerate(response) if all(x in s for x in diagMsgReqKeys)]
+                    diag_mgs_req_keys = ['mode', 'bus', 'id', 'success']
+                    indices = [i for i, s in enumerate(response) if all(x in s for x in diag_mgs_req_keys)]
                     if indices:
                         print(("Response: %s" % response[indices[0]]))
                 else:

openxc/tools/static/css/dashboard.css

@@ -37,6 +37,7 @@ caption {
 table, th, td {
 	text-align: left;
 	border-spacing: 8px 1px;
+	border: 1px solid black;
 }
 
 .metric {
@@ -48,10 +49,6 @@ th:hover {
 	background-color: #AAA;
 }
 
-table, th, td {
-	border: 1px solid black;
-}
-
 table {
 	padding-top: 2%;
 	padding-bottom: 2%;

openxc/tools/static/js/dashboard.js

@@ -6,6 +6,9 @@ let recentlyChangedHighlightDuration;
 let diagnosticCount = 0;
 /* --- End dashboard parameters --- */
 
+var valueChangedTimer;
+var valueRecentlyChangedTimer;
+
 $(document).ready(function() {
 	updateDashboardParameters();
 	searchTable()
@@ -34,7 +37,7 @@ $(document).ready(function() {
 	});
 
 
-	namespace = '';
+	var namespace = '';
 	var socket = io(namespace);
 	socket.on('vehicle data', function(msg, cb) {
 		// console.log(msg);
@@ -90,12 +93,9 @@ function saveSettings(e) {
 }
 
 function addToDisplay(msgName) {
-	var added = false;
-	if (!added) {
-		$('<tr/>', {
-			id: msgName
-		}).appendTo('#log');
-	}
+	$('<tr/>', {
+		id: msgName
+	}).appendTo('#log');
 
 	$('<td/>', {
 		id: msgName + '_label',
@@ -118,9 +118,9 @@ function addToDisplay(msgName) {
 }
 
 function updateDisplay(dataPoint) {
-	msg = dataPoint.current_data
+	var msg = dataPoint.current_data
 
-	if (!($('#' + msg.name).length > 0)) {
+	if ($('#' + msg.name).length <= 0) {
 		addToDisplay(msg.name);
 	}