Small enhancements following review

Author: benoit74

pyproject.toml

@@ -279,6 +279,7 @@ exclude_lines = [
   "if __name__ == .__main__.:",
   "if TYPE_CHECKING:",
   "class .*Protocol.*",
+  "@abstractmethod",
 ]
 
 [tool.pyright]

src/zimscraperlib/image/__init__.py

@@ -1,7 +1,6 @@
-# flake8: noqa
-from .conversion import convert_image
-from .optimization import optimize_image
-from .probing import is_valid_image
-from .transformation import resize_image
+from zimscraperlib.image.conversion import convert_image
+from zimscraperlib.image.optimization import optimize_image
+from zimscraperlib.image.probing import is_valid_image
+from zimscraperlib.image.transformation import resize_image
 
 __all__ = ["convert_image", "is_valid_image", "optimize_image", "resize_image"]

src/zimscraperlib/video/__init__.py

@@ -1,7 +1,5 @@
-from .config import Config
+from zimscraperlib.video.config import Config
+from zimscraperlib.video.encoding import reencode
+from zimscraperlib.video.probing import get_media_info
 
-# flake8: noqa
-from .encoding import reencode
-from .probing import get_media_info
-
-__all__ = ["Config", "reencode", "get_media_info"]
+__all__ = ["Config", "get_media_info", "reencode"]

src/zimscraperlib/video/probing.py

@@ -2,7 +2,7 @@
 import subprocess
 
 
-def get_media_info(src_path: str | pathlib.Path):
+def get_media_info(src_path: pathlib.Path):
     """dict of file's details from ffprobe
 
     codecs: list of codecs in use

src/zimscraperlib/zim/metadata.py

@@ -148,14 +148,14 @@ def validate(self) -> None:
         _ = self.libzim_value
 
     @abstractmethod
-    def get_cleaned_value(self, value: Any) -> T: ...  # pragma: no cover
+    def get_cleaned_value(self, value: Any) -> T: ...
 
     @property
     def libzim_value(self) -> bytes:
         return self.get_libzim_value()
 
     @abstractmethod
-    def get_libzim_value(self) -> bytes: ...  # pragma: no cover
+    def get_libzim_value(self) -> bytes: ...
 
 
 # Alias for convenience when function accept any metadata
@@ -236,12 +236,12 @@ def get_binary_from(
         elif isinstance(value, bytes):
             bvalue = value
         else:
-            last_pos: int
+            last_pos: int = 0
             if isinstance(value, SupportsSeekableRead) and value.seekable():
                 last_pos = value.tell()
             bvalue = value.read()
             if isinstance(value, SupportsSeekableRead) and value.seekable():
-                value.seek(last_pos)  # pyright: ignore[reportPossiblyUnboundVariable]
+                value.seek(last_pos)
         if not self.empty_allowed and not value:
             raise ValueError("Missing value (empty not allowed)")
         return bvalue
@@ -495,8 +495,8 @@ def get_reserved_names(cls) -> list[str]:
         for field in fields(cls):
             if not isinstance(field.type, type):
                 continue
-            # if field type is a type, it means that it is required (otherwise field
-            # type is a string when None is allowed)
+            # field.type is a `type` only when expecting a single type
+            # and is a string in case of None Union
             names.append(getattr(field.type, "meta_name", ""))
         return names
 

tests/filesystem/test_filesystem.py

@@ -33,7 +33,7 @@ def test_content_mimetype_fallback(
     assert get_content_mimetype(undecodable_byte_stream) == "application/octet-stream"
 
     # mock then so we keep coverage on systems where magic works
-    def raising_magic(*_: Any, **__: Any):
+    def raising_magic(*args: Any, **kwargs: Any):  # noqa: ARG001
         raise UnicodeDecodeError("nocodec", b"", 0, 1, "noreason")
 
     monkeypatch.setattr(magic, "from_buffer", raising_magic)