chore: bump spotbugs 4.10.2.0 and related fixes (#3458)

* chore(deps): bump com.github.spotbugs:spotbugs-maven-plugin

Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.9.8.3 to 4.10.2.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.9.8.3...spotbugs-maven-plugin-4.10.2.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-version: 4.10.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump: 4.10.2.0 and related fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: csviri

migration/src/main/java/io/javaoperatorsdk/operator/migration/RemoveMethodDeclaration.java

@@ -59,13 +59,13 @@ public J.ClassDeclaration visitClassDeclaration(
           J.ClassDeclaration classDecl, ExecutionContext ctx) {
         J.ClassDeclaration cd = super.visitClassDeclaration(classDecl, ctx);
 
-        if (cd.getType() == null || !typeMatchesOrImplements(cd.getType())) {
+        JavaType.FullyQualified type = cd.getType();
+        if (type == null || !typeMatchesOrImplements(type)) {
           return cd;
         }
 
         // Mutate the type info in place to remove the method from the declared methods list,
         // so all AST nodes sharing this type reference stay consistent.
-        var type = cd.getType();
         if (type instanceof JavaType.Class classType) {
           var updatedMethods =
               classType.getMethods().stream().filter(m -> !m.getName().equals(methodName)).toList();
@@ -90,11 +90,16 @@ public J.MethodDeclaration visitMethodDeclaration(
         }
 
         J.ClassDeclaration classDecl = getCursor().firstEnclosing(J.ClassDeclaration.class);
-        if (classDecl == null || classDecl.getType() == null) {
+        if (classDecl == null) {
           return super.visitMethodDeclaration(method, ctx);
         }
 
-        if (typeMatchesOrImplements(classDecl.getType())) {
+        JavaType.FullyQualified type = classDecl.getType();
+        if (type == null) {
+          return super.visitMethodDeclaration(method, ctx);
+        }
+
+        if (typeMatchesOrImplements(type)) {
           //noinspection DataFlowIssue
           return null;
         }

pom.xml

@@ -103,7 +103,7 @@
     <git-commit-id-maven-plugin.version>10.0.0</git-commit-id-maven-plugin.version>
     <jib-maven-plugin.version>3.5.1</jib-maven-plugin.version>
     <spotless.version>3.8.0</spotless.version>
-    <spotbugs-maven-plugin.version>4.9.8.3</spotbugs-maven-plugin.version>
+    <spotbugs-maven-plugin.version>4.10.2.0</spotbugs-maven-plugin.version>
   </properties>
 
   <dependencyManagement>