improve: using fabric8 re-list callback to cover event filtering edge cases

Fabric8 client now supports callback onBeforeList in Informers, that
allows to enhance edge case support for event filtering:
Since on re-list some events could be lost, we will trigger the reconciliation in such scenarios.

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

@@ -155,16 +155,14 @@ public synchronized void stop() {
 
   @Override
   public void onList(String resourceVersion, boolean remainedEmpty) {
-    //  re-list supported by fabric8 client https://github.com/fabric8io/kubernetes-client/pull/7899
-    //    temporaryResourceCache.setRelistFinished(resourceVersion);
+    temporaryResourceCache.setRelistFinished(resourceVersion);
     temporaryResourceCache.checkGhostResources();
   }
 
-  //  @Override (enable when
-  //  re-list supported by fabric8 client https://github.com/fabric8io/kubernetes-client/pull/7899
-  //  public void onBeforeList(String lastSyncResourceVersion) {
-  //    temporaryResourceCache.setOngoingRelist(lastSyncResourceVersion);
-  //  }
+  @Override
+  public void onBeforeList(String lastSyncResourceVersion) {
+    temporaryResourceCache.setOngoingRelist(lastSyncResourceVersion);
+  }
 
   @Override
   public void handleRecentResourceUpdate(

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/EventFilterWindowTest.java

@@ -15,7 +15,6 @@
  */
 package io.javaoperatorsdk.operator.processing.event.source.informer;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import io.fabric8.kubernetes.api.model.ConfigMap;
@@ -385,25 +384,6 @@ void additionalEventAndDeleteEvent() {
     assertThat(eventFilterWindow.canBeRemoved()).isTrue();
   }
 
-  @Test
-  @Disabled("should be part of event filter support")
-  void additionalEventAndDeleteEventNoUpdate() {
-    eventFilterWindow.increaseActiveUpdates();
-    eventFilterWindow.addToOwnUpdateVersions(s(FIRST_OWN_VERSION));
-    eventFilterWindow.addRelatedEvent(updateEvent(FIRST_OWN_VERSION));
-    eventFilterWindow.addRelatedEvent(updateEvent(FIRST_OWN_VERSION + 1));
-    eventFilterWindow.addRelatedEvent(deleteEvent(FIRST_OWN_VERSION + 2));
-
-    assertThat(eventFilterWindow.check())
-        .hasValueSatisfying(e -> assertDeleteEvent(e, FIRST_OWN_VERSION + 2));
-    assertThat(eventFilterWindow.check()).isEmpty();
-
-    assertEmptyState();
-    eventFilterWindow.decreaseActiveUpdates();
-
-    assertThat(eventFilterWindow.canBeRemoved()).isTrue();
-  }
-
   @Test
   void deleteEventInMiddleTwoUpdates() {
     eventFilterWindow.increaseActiveUpdates();

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/onrelistfilter/OnRelistFilterIT.java

@@ -17,7 +17,6 @@
 
 import java.time.Duration;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
@@ -37,7 +36,6 @@
  *   <li>re-list starts WHILE the update window is open — own write is propagated
  * </ul>
  */
-@Disabled("enable when fabric8 supports relist")
 class OnRelistFilterIT {
 
   static final String RESOURCE_NAME = "test-resource";

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/onrelistfilter/OnRelistFilterReconciler.java

@@ -160,8 +160,7 @@ static class RelistAwareInformerEventSource<R extends HasMetadata, P extends Has
     }
 
     void simulateOnBeforeList() {
-      // uncomment when fabric8 supports re-list
-      //      onBeforeList(null);
+      onBeforeList(null);
     }
 
     void simulateOnList() {

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/ownsecondaryupdate/OwnSecondaryUpdateIT.java

@@ -17,7 +17,6 @@
 
 import java.time.Duration;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
@@ -33,7 +32,6 @@
  * the secondary are filtered and do NOT trigger additional reconciliations. Counterpart to {@code
  * ExternalSecondaryUpdateIT}, which asserts the opposite for third-party updates.
  */
-@Disabled("enable if re-list notification supported by fabric8 client")
 class OwnSecondaryUpdateIT {
 
   static final String RESOURCE_NAME = "test-resource";