Skip to content

Commit c2c90e4

Browse files
committed
Remove remaining added code comments & JavaDocs
Signed-off-by: Dennis-Mircea Ciupitu <dennis.mircea.ciupitu@gmail.com>
1 parent a7fbdf2 commit c2c90e4

2 files changed

Lines changed: 0 additions & 27 deletions

File tree

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ public class LeaderElectionManager {
5555
private final ConfigurationService configurationService;
5656
private String leaseNamespace;
5757
private String leaseName;
58-
// Set in stop() before cancelling the leader-election future. Checked in stopLeading() so that
59-
// a graceful shutdown does not call System.exit, which would otherwise deadlock against the
60-
// JVM shutdown hook lock when stop() is invoked from a JVM shutdown hook.
6158
private final AtomicBoolean stoppingGracefully = new AtomicBoolean(false);
6259

6360
LeaderElectionManager(

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -210,30 +210,6 @@ public synchronized void start() {
210210
}
211211
}
212212

213-
/**
214-
* Stops the operator and releases its resources. The shutdown sequence is:
215-
*
216-
* <ol>
217-
* <li>Stop the controller manager, halting reconciliation of all registered controllers.
218-
* <li>Stop the executor service manager, waiting up to {@link
219-
* io.javaoperatorsdk.operator.api.config.ConfigurationService#reconciliationTerminationTimeout()}
220-
* for in-flight reconciliations to complete.
221-
* <li>Stop the leader-election manager, cancelling the leader-election future and releasing any
222-
* held lease.
223-
* <li>Close the {@link KubernetesClient} if {@link
224-
* io.javaoperatorsdk.operator.api.config.ConfigurationService#closeClientOnStop()} is
225-
* {@code true} (the default).
226-
* </ol>
227-
*
228-
* <p>It is safe to call this method from a JVM shutdown hook (see {@link #installShutdownHook()})
229-
* as the graceful-shutdown path coordinates with the leader-election callbacks so that {@code
230-
* System.exit} is not invoked while the JVM is already shutting down.
231-
*
232-
* <p>If the operator was never successfully started, this method only stops the executor service
233-
* manager so that no thread pools are leaked.
234-
*
235-
* @throws OperatorException if an error occurs during shutdown
236-
*/
237213
@Override
238214
public void stop() throws OperatorException {
239215
Duration reconciliationTerminationTimeout =

0 commit comments

Comments
 (0)