Skip to content

Commit d2964b7

Browse files
committed
Fix formatting
Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
1 parent 96c0b9e commit d2964b7

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/statuseventfiltering/StatusEventFilteringIT.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class StatusEventFilteringIT {
4949
.build();
5050

5151
@Test
52-
@Disabled("https://github.com/operator-framework/java-operator-sdk/issues/XXXX")
52+
@Disabled("https://github.com/operator-framework/java-operator-sdk/issues/3445")
5353
void mapperShouldFireAfterStatusPatchThroughSharedEventSource() {
5454
var primaryReconciler = extension.getReconcilerOfType(StatusEventPrimaryReconciler.class);
5555

@@ -65,16 +65,20 @@ void mapperShouldFireAfterStatusPatchThroughSharedEventSource() {
6565
secondary.getSpec().setValue("initial");
6666
extension.create(secondary);
6767

68-
// When: the primary resource is created, triggering reconciliation which patches
69-
// the secondary's observedGeneration=1 through the shared InformerEventSource
7068
var primary = new StatusEventPrimaryResource();
7169
primary.setMetadata(
7270
new ObjectMetaBuilder()
7371
.withName("test-primary")
7472
.withNamespace(extension.getNamespace())
7573
.build());
74+
75+
// When: the primary resource is created, triggering reconciliation which patches
76+
// the secondary's observedGeneration=1 through the shared InformerEventSource
7677
extension.create(primary);
7778

79+
// Then: the mapper should see gen==obsGen and trigger a second reconciliation.
80+
// With the bug, the EventFilterWindow suppresses the status-change event
81+
// so the mapper never fires — the controller is stuck at 1 execution.
7882
await()
7983
.atMost(Duration.ofSeconds(30))
8084
.untilAsserted(
@@ -85,9 +89,6 @@ void mapperShouldFireAfterStatusPatchThroughSharedEventSource() {
8589
.isEqualTo(sec.getMetadata().getGeneration());
8690
});
8791

88-
// Then: the mapper should see gen==obsGen and trigger a second reconciliation.
89-
// With the bug, the EventFilterWindow suppresses the status-change event
90-
// so the mapper never fires — the controller is stuck at 1 execution.
9192
await()
9293
.atMost(Duration.ofSeconds(15))
9394
.pollInterval(Duration.ofMillis(500))

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/statuseventfiltering/StatusEventPrimaryResource.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,4 @@
2424
@Group("sample.javaoperatorsdk")
2525
@Version("v1")
2626
@ShortNames("sepr")
27-
public class StatusEventPrimaryResource extends CustomResource<Void, Void>
28-
implements Namespaced {}
27+
public class StatusEventPrimaryResource extends CustomResource<Void, Void> implements Namespaced {}

0 commit comments

Comments
 (0)