operator-controller/internal/operator-controller/bundleutil/bundle_test.go at 3cca49747cbd4c5e8db80b2b19ddd75809a455ad · operator-framework/operator-controller · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
package bundleutil_test

import (
	"encoding/json"
	"testing"

	bsemver "github.com/blang/semver/v4"
	"github.com/stretchr/testify/require"

	"github.com/operator-framework/operator-registry/alpha/declcfg"
	"github.com/operator-framework/operator-registry/alpha/property"

	"github.com/operator-framework/operator-controller/internal/operator-controller/bundle"
	"github.com/operator-framework/operator-controller/internal/operator-controller/bundleutil"
)

func TestGetVersionAndRelease(t *testing.T) {
	tests := []struct {
		name               string
		pkgProperty        *property.Property
		wantVersionRelease *bundle.VersionRelease
		wantErr            bool
	}{
		{
			name: "valid version",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`{"version": "1.0.0-pre+1.alpha.2"}`),
			},
			wantVersionRelease: &bundle.VersionRelease{
				Version: bsemver.MustParse("1.0.0-pre"),
				Release: bundle.Release([]bsemver.PRVersion{
					{VersionNum: 1, IsNum: true},
					{VersionStr: "alpha"},
					{VersionNum: 2, IsNum: true},
				}),
			},
			wantErr: false,
		},
		{
			name: "invalid version",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`{"version": "abcd"}`),
			},
			wantErr: true,
		},
		{
			name: "invalid release - build metadata with leading zeros",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`{"version": "1.0.0+001"}`),
			},
			wantVersionRelease: &bundle.VersionRelease{
				Version: bsemver.MustParse("1.0.0+001"),
			},
			wantErr: false,
		},
		{
			name: "invalid json",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`abcd`),
			},
			wantErr: true,
		},
		{
			name:        "no version property",
			pkgProperty: nil,
			wantErr:     true,
		},
		{
			name: "explicit release field - takes precedence over build metadata",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`{"version": "1.0.0+ignored", "release": "2"}`),
			},
			wantVersionRelease: &bundle.VersionRelease{
				Version: bsemver.MustParse("1.0.0+ignored"),
				Release: bundle.Release([]bsemver.PRVersion{
					{VersionNum: 2, IsNum: true},
				}),
			},
			wantErr: false,
		},
		{
			name: "explicit release field - complex release",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`{"version": "2.1.0", "release": "1.alpha.3"}`),
			},
			wantVersionRelease: &bundle.VersionRelease{
				Version: bsemver.MustParse("2.1.0"),
				Release: bundle.Release([]bsemver.PRVersion{
					{VersionNum: 1, IsNum: true},
					{VersionStr: "alpha"},
					{VersionNum: 3, IsNum: true},
				}),
			},
			wantErr: false,
		},
		{
			name: "explicit release field - invalid release",
			pkgProperty: &property.Property{
				Type:  property.TypePackage,
				Value: json.RawMessage(`{"version": "1.0.0", "release": "001"}`),
			},
			wantErr: true,
		},
	}

	for _, tc := range tests {
		t.Run(tc.name, func(t *testing.T) {
			properties := make([]property.Property, 0)
			if tc.pkgProperty != nil {
				properties = append(properties, *tc.pkgProperty)
			}

			bundle := declcfg.Bundle{
				Name:       "test-bundle",
				Properties: properties,
			}

			actual, err := bundleutil.GetVersionAndRelease(bundle)
			if tc.wantErr {
				require.Error(t, err)
			} else {
				require.NoError(t, err)
				require.Equal(t, tc.wantVersionRelease, actual)
			}
		})
	}
}