-
Notifications
You must be signed in to change notification settings - Fork 631
[BUG]: Test file checker doesn't catch existing tests #6188
Copy link
Copy link
Open
Labels
Impact: MediumModerate perceived user impact (non-blocking bugs and general improvements).Moderate perceived user impact (non-blocking bugs and general improvements).Work: MediumThe means to find the solution is clear, but it isn't at good-first-issue level yet.The means to find the solution is clear, but it isn't at good-first-issue level yet.bugEnd user-perceivable behaviors which are not desirable.End user-perceivable behaviors which are not desirable.
Metadata
Metadata
Assignees
Labels
Impact: MediumModerate perceived user impact (non-blocking bugs and general improvements).Moderate perceived user impact (non-blocking bugs and general improvements).Work: MediumThe means to find the solution is clear, but it isn't at good-first-issue level yet.The means to find the solution is clear, but it isn't at good-first-issue level yet.bugEnd user-perceivable behaviors which are not desirable.End user-perceivable behaviors which are not desirable.
Describe the bug
If an existing test is exempted with type
test_file_not_requiredthenTestFileCheckwill happily ignore it even though it exists.Steps To Reproduce
Add an exemption for an existing test to
test_file_exemptions.textproto, e.g.:Then run the check:
bazel run //scripts:test_file_check -- $(pwd)MathExpressionParserTestexists yet the above will still pass.Expected Behavior
TestFileCheckshould fail if an existing test is marked as not needed because it obviously exists.Screenshots/Videos
No response
What device/emulator are you using?
No response
Which Android version is your device/emulator running?
No response
Which version of the Oppia Android app are you using?
No response
Additional Context
No response