Skip to content

[BUG]: Test file checker doesn't catch existing tests #6188

@BenHenning

Description

@BenHenning

Describe the bug

If an existing test is exempted with type test_file_not_required then TestFileCheck will happily ignore it even though it exists.

Steps To Reproduce

Add an exemption for an existing test to test_file_exemptions.textproto, e.g.:

test_file_exemption {
  exempted_file_path: "utility/src/main/java/org/oppia/android/util/math/MathExpressionParser.kt"
  test_file_not_required: true
}

Then run the check:

bazel run //scripts:test_file_check -- $(pwd)

MathExpressionParserTest exists yet the above will still pass.

Expected Behavior

TestFileCheck should fail if an existing test is marked as not needed because it obviously exists.

Screenshots/Videos

No response

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Impact: MediumModerate perceived user impact (non-blocking bugs and general improvements).Work: MediumThe means to find the solution is clear, but it isn't at good-first-issue level yet.bugEnd user-perceivable behaviors which are not desirable.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions