test fixes

Author: raju-opti

lib/core/decision_service/index.ts

@@ -290,11 +290,12 @@ export class DecisionService {
       this.getDecisionFromBucketer(op, configObj, experiment, user);
 
     return decisionVariationValue.then((variationResult): Value<OP, VariationResult> => {
+      decideReasons.push(...variationResult.reasons);
       if (variationResult.error) {
         return Value.of(op, {
           error: true,
           result: {},
-          reasons: [...decideReasons, ...variationResult.reasons],
+          reasons: decideReasons,
         });
       }
 
@@ -509,7 +510,7 @@ export class DecisionService {
     options: DecideOptionsMap = {}
   ): DecisionResponse<string | null> {
     const shouldIgnoreUPS = options[OptimizelyDecideOption.IGNORE_USER_PROFILE_SERVICE];
-    let userProfileTracker: Maybe<UserProfileTracker> = shouldIgnoreUPS ? undefined
+    const userProfileTracker: Maybe<UserProfileTracker> = shouldIgnoreUPS ? undefined
       : {
         isProfileUpdated: false,
         userProfile: this.resolveExperimentBucketMap('sync', user.getUserId(), user.getAttributes()).get(),
@@ -938,7 +939,10 @@ export class DecisionService {
     decideOptions: DecideOptionsMap,
     userProfileTracker?: UserProfileTracker
   ): Value<OP, DecisionResult> {
+    const decideReasons: DecisionReason[] = [];
+
     const forcedDecisionResponse = this.findValidatedForcedDecision(configObj, user, feature.key);
+    decideReasons.push(...forcedDecisionResponse.reasons);
 
     if (forcedDecisionResponse.result) {
       return Value.of(op, {
@@ -947,7 +951,7 @@ export class DecisionService {
           experiment: null,
           decisionSource: DECISION_SOURCES.FEATURE_TEST,
         },
-        reasons: forcedDecisionResponse.reasons,
+        reasons: decideReasons,
       });
     }
 
@@ -956,7 +960,7 @@ export class DecisionService {
         return Value.of(op, experimentDecision);
       }
 
-      const decideReasons = experimentDecision.reasons;
+      decideReasons.push(...experimentDecision.reasons);
 
       const rolloutDecision = this.getVariationForRollout(configObj, feature, user);
       decideReasons.push(...rolloutDecision.reasons);

lib/optimizely/index.tests.js

@@ -224,19 +224,23 @@ describe('lib/optimizely', function() {
             save: function() {},
           };
 
+          const cmabService = {};
+
           new Optimizely({
             clientEngine: 'node-sdk',
             logger: createdLogger,
             projectConfigManager: getMockProjectConfigManager(),
             jsonSchemaValidator: jsonSchemaValidator,
             userProfileService: userProfileServiceInstance,
             notificationCenter,
+            cmabService,
             eventProcessor,
           });
 
           sinon.assert.calledWith(decisionService.createDecisionService, {
             userProfileService: userProfileServiceInstance,
             logger: createdLogger,
+            cmabService,
             UNSTABLE_conditionEvaluators: undefined,
           });
 
@@ -251,6 +255,8 @@ describe('lib/optimizely', function() {
             save: function() {},
           };
 
+          const cmabService = {};
+          
           new Optimizely({
             clientEngine: 'node-sdk',
             logger: createdLogger,
@@ -259,12 +265,14 @@ describe('lib/optimizely', function() {
             userProfileService: invalidUserProfile,
             notificationCenter,
             eventProcessor,
+            cmabService,
           });
 
           sinon.assert.calledWith(decisionService.createDecisionService, {
             userProfileService: undefined,
             logger: createdLogger,
             UNSTABLE_conditionEvaluators: undefined,
+            cmabService,
           });
 
           // var logMessage = buildLogMessageFromArgs(createdLogger.log.args[0]);
@@ -5261,6 +5269,7 @@ describe('lib/optimizely', function() {
             userId,
           });
           var decision = optlyInstance.decide(user, flagKey);
+
           expect(decision.reasons).to.include(
             sprintf(USER_BUCKETED_INTO_EXPERIMENT_IN_GROUP, userId, experimentKey, groupId)
           );

lib/utils/promise/operation_value.ts

@@ -2,7 +2,8 @@ import { PROMISE_NOT_ALLOWED } from '../../message/error_message';
 import { OptimizelyError } from '../../error/optimizly_error';
 import { OpType, OpValue } from '../type';
 
-export const isPromise = (val: any): boolean => {
+
+const isPromise = (val: any): boolean => {
   return val && typeof val.then === 'function';
 }
 

package.json

@@ -53,7 +53,7 @@
     "clean:win": "(if exist dist rd /s/q dist)",
     "lint": "tsc --noEmit && eslint 'lib/**/*.js' 'lib/**/*.ts'",
     "test-vitest": "vitest run",
-    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r tsconfig-paths/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/decision_service/index.tests.js'",
+    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r tsconfig-paths/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/*.tests.js'",
     "test": "npm run test-mocha && npm run test-vitest",
     "posttest": "npm run lint",
     "test-ci": "npm run test-xbrowser && npm run test-umdbrowser",