Skip to content

Commit f4a60ac

Browse files
[FSSDK-12249] cleanup
1 parent 13928f4 commit f4a60ac

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/client/client.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,13 @@ describe('createInstance', () => {
8585
expect(meta.hasOdpManager).toBe(true);
8686
});
8787

88-
it('should set isVuidEnabled to false when vuidManager is not provided', () => {
88+
it('should set hasVuidManager to false when vuidManager is not provided', () => {
8989
const client = createInstance(createTestConfig());
9090
const meta = (client as unknown as ClientWithMeta)[REACT_CLIENT_META];
9191
expect(meta.hasVuidManager).toBe(false);
9292
});
9393

94-
it('should set isVuidEnabled to true when vuidManager is provided', () => {
94+
it('should set hasVuidManager to true when vuidManager is provided', () => {
9595
const client = createInstance(createTestConfig({ vuidManager: {} as Config['vuidManager'] }));
9696
const meta = (client as unknown as ClientWithMeta)[REACT_CLIENT_META];
9797
expect(meta.hasVuidManager).toBe(true);

src/provider/OptimizelyProvider.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ export function OptimizelyProvider({
6060
[client, store]
6161
);
6262

63+
// Effect 1: client lifecycle (onReady and error handling)
6364
useEffect(() => {
6465
if (!client) {
6566
logger?.error('OptimizelyProvider must be passed an Optimizely client instance');

src/utils/UserContextManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ export class UserContextManager {
113113
return;
114114
}
115115

116-
// Step 3: Original path (no qualifiedSegments)
116+
// odpManager and no qualifiedSegments
117117
if (!this.skipSegments && this.meta.hasOdpManager) {
118118
await this.client.onReady();
119119
if (this.isStale(requestId)) return;

0 commit comments

Comments
 (0)