Fix test case errors

Author: esrakartalOpt

lib/optimizely/cmab/cmab_client.rb

@@ -73,7 +73,7 @@ def fetch_decision(rule_id, user_id, attributes, cmab_uuid, timeout: MAX_WAIT_TI
         }]
       }
 
-      if @retry_config
+      if @retry_config && @retry_config.max_retries.to_i > 0
         _do_fetch_with_retry(url, request_body, @retry_config, timeout)
       else
         _do_fetch(url, request_body, timeout)
@@ -95,27 +95,27 @@ def _do_fetch(url, request_body, timeout)
         response = @http_client.post(url, json: request_body, headers: headers, timeout: timeout)
       rescue StandardError => e
         error_message = Optimizely::Helpers::Constants::CMAB_FETCH_FAILED % e.message
-        @logger.error(error_message)
+        @logger.error(Logger::ERROR, error_message)
         raise CmabFetchError, error_message
       end
 
       unless (200..299).include?(response.status_code)
         error_message = Optimizely::Helpers::Constants::CMAB_FETCH_FAILED % response.status_code
-        @logger.error(error_message)
+        @logger.error(Logger::ERROR, error_message)
         raise CmabFetchError, error_message
       end
 
       begin
         body = response.json
       rescue JSON::ParserError
         error_message = Optimizely::Helpers::Constants::INVALID_CMAB_FETCH_RESPONSE
-        @logger.error(error_message)
+        @logger.error(Logger::ERROR, error_message)
         raise CmabInvalidResponseError, error_message
       end
 
       unless validate_response(body)
         error_message = Optimizely::Helpers::Constants::INVALID_CMAB_FETCH_RESPONSE
-        @logger.error(error_message)
+        @logger.error(Logger::ERROR, error_message)
         raise CmabInvalidResponseError, error_message
       end
 
@@ -158,14 +158,14 @@ def _do_fetch_with_retry(url, request_body, retry_config, timeout)
       rescue => e
         last_error = e
         if attempt < retry_config.max_retries
-          @logger.info("Retrying CMAB request (attempt: #{attempt + 1} after #{backoff} seconds)...")
+          @logger.info(Logger::INFO, "Retrying CMAB request (attempt: #{attempt + 1} after #{backoff} seconds)...")
           sleep(backoff)
           backoff = [backoff * (retry_config.backoff_multiplier**(attempt + 1)), retry_config.max_backoff].min
         end
       end
 
       error_message = Optimizely::Helpers::Constants::CMAB_FETCH_FAILED % (last_error&.message || 'Max retries exceeded for CMAB request.')
-      @logger.error(error_message)
+      @logger.error(Logger::ERROR, error_message)
       raise CmabFetchError, error_message
     end
   end

spec/cmab_client_spec.rb

@@ -54,7 +54,7 @@
       hash_including(
         json: expected_body,
         headers: expected_headers,
-        timeout: 10
+        timeout: 10.0
       )
     )
   end
@@ -82,7 +82,7 @@
       hash_including(
         json: expected_body,
         headers: expected_headers,
-        timeout: 10
+        timeout: 10.0
       )
     )
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('500'))
@@ -102,7 +102,7 @@
       hash_including(
         json: expected_body,
         headers: expected_headers,
-        timeout: 10
+        timeout: 10.0
       )
     )
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Invalid CMAB fetch response'))
@@ -121,7 +121,7 @@
       hash_including(
         json: expected_body,
         headers: expected_headers,
-        timeout: 10
+        timeout: 10.0
       )
     )
     expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Invalid CMAB fetch response'))
@@ -143,7 +143,7 @@
       hash_including(
         json: expected_body,
         headers: expected_headers,
-        timeout: 10
+        timeout: 10.0
       )
     ).once
     expect_any_instance_of(Object).not_to have_received(:sleep)
@@ -173,7 +173,7 @@
       hash_including(
         json: expected_body,
         headers: expected_headers,
-        timeout: 10
+        timeout: 10.0
       )
     )