Skip to content

Commit 5e77972

Browse files
authored
Fix TypeError in sync_ironic by adding missing request_id parameter (#1849)
Two calls to push_task_output() were missing the required request_id parameter, causing "missing 1 required positional argument: 'line'" errors. - Fixed line 232: Added request_id parameter for node removal failure message - Fixed line 396: Added request_id parameter for lock acquisition failure message - Changed line 396 to use f-string for proper device.name interpolation AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
1 parent 8ee7086 commit 5e77972

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

osism/tasks/conductor/ironic.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,8 @@ def sync_ironic(request_id, get_ironic_parameters, node_name=None, force=False):
230230
openstack.baremetal_node_delete(node["uuid"])
231231
else:
232232
osism_utils.push_task_output(
233-
f"Cannot remove baremetal node because it is still provisioned or running: {node}"
233+
request_id,
234+
f"Cannot remove baremetal node because it is still provisioned or running: {node}\n",
234235
)
235236

236237
# NOTE: Find nodes in NetBox which are not present in Ironic and add them
@@ -394,7 +395,7 @@ def sync_ironic(request_id, get_ironic_parameters, node_name=None, force=False):
394395

395396
else:
396397
osism_utils.push_task_output(
397-
"Could not acquire lock for node {device.name}"
398+
request_id, f"Could not acquire lock for node {device.name}\n"
398399
)
399400

400401
osism_utils.finish_task_output(request_id, rc=0)

0 commit comments

Comments
 (0)