Skip to content

Commit c06e94b

Browse files
committed
Drop secure.yaml warning and sample file
Users following the deployment guide see the warning "There is no file terraform/secure.yaml, create one by using terraform/secure.yaml.sample as template" in their log output. This is confusing because the guide recommends application credentials, where the secret is already in clouds.yaml and no secure.yaml is needed. Remove the secure.yaml existence check from setup-testbed.py and delete terraform/secure.yaml.sample. The check was already non-fatal (warning + sleep, no exit) — a compromise from PR #1879 where it was noted that secure.yaml is optional for app credentials. A TODO to add smarter detection was left but never followed up on. The deployment guide now exclusively recommends application credentials (osism/osism.github.io#972). For production deployments, a more fine-grained check that validates credentials based on auth type would still be valuable. AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
1 parent e9a3143 commit c06e94b

2 files changed

Lines changed: 0 additions & 20 deletions

File tree

contrib/setup-testbed.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import sys
88
import yaml
99
import os
10-
import time
1110

1211

1312
def lookup(yaml_path: str, local_data: dict) -> None | str | dict:
@@ -48,14 +47,6 @@ def _check_file(filename: str, name: str):
4847
print(e)
4948
sys.exit(1)
5049

51-
# TODO: as discussed in https://github.com/osism/testbed/pull/1879 we add a app credential check later
52-
# to make a smart distinction if that check is needed or not.
53-
try:
54-
_check_file("terraform/secure.yaml", cloud)
55-
except Exception as e:
56-
print(e)
57-
time.sleep(2)
58-
5950
sys.exit(0)
6051

6152

terraform/secure.yaml.sample

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)