Merge pull request #23 from antoinelyset/guard-out-of-bound-array-insert

Raise an error when inserting in out of bounds array index

Author: josephg

lib/json1.ts

@@ -157,6 +157,7 @@ function removeChild(container: Doc[] | DocObj, key: Key) {
 function insertChildMut(container: Doc[] | DocObj, key: Key, value: Doc) {
   if (typeof key === 'number') {
     assert(Array.isArray(container), 'Cannot use numerical key for object container')
+    assert(container.length >= key, 'Cannot insert into out of bounds index')
     //container = container.slice()
     container.splice(key, 0, value)
   } else {

test/test.js

@@ -636,6 +636,10 @@ describe('json1', () => {
 
     it('throws if the type is missing', () =>
       assert.throws(() => type.apply({}, [{ et: 'missing', e: {} }])))
+
+    it('throws when the op inserts in out of bound index', () => {
+      assert.throws(() => type.apply([0], [2, { i: 2 }]))
+    })
   })
 
   describe('apply path', () => {